fix: allow use of createBrowserClient without window present
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Jun 24, 2024
activenode
reviewed
Jun 24, 2024
|
I think that looks great |
hf
force-pushed
the
hf/fix-allow-use-of-create-browser-client-without-window
branch
from
45f860b to
58fe199
Compare
hf
pushed a commit
that referenced
this pull request
Jun 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2024-06-24) ### Features * full rewrite using `getAll` and `setAll` cookie methods ([#1](#1)) ([b6ae192](b6ae192)) ### Bug Fixes * allow use of `createBrowserClient` without `window` present ([#20](#20)) ([27d868d](27d868d)) * deprecate `parse`, `serialize` exports for more useful functions ([#14](#14)) ([0b5f881](0b5f881)) * fix `createBrowserClient` deprecation tsdoc ([#17](#17)) ([1df70ad](1df70ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows calling
createBrowserClientwithout throwing an error when not in a browser context (i.e.windowis missing).This is especially useful when using in Next.js Pre-Rendering mode where the client's non-
authnamespaces could be useful, such as to load public data from PostgREST.If however the
authnamespace is used, thesetAllhandler function will throw an error indicating to the user that they're doing something wrong. This shouldn't come up in Pre-Rendering mode ever.See: https://github.com/orgs/supabase/discussions/27037#discussioncomment-9852948