Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from poetry-cookiecutter to substrate #98

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

rchretien
Copy link
Contributor

No description provided.

@rchretien rchretien linked an issue Feb 21, 2025 that may be closed by this pull request
@rchretien rchretien added the enhancement New feature or request label Feb 21, 2025
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rchretien!

To fix the build issue, we need to add an upper bound on NumPy: <2.0.0. Otherwise, uv cannot resolve the environment and tries building llvmlite, which fails.

@rchretien rchretien changed the title feat: migrate from poetry-cookicutter to substrate feat: migrate from poetry-cookiecutter to substrate Feb 24, 2025
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments from another review pass.

ragas = { version = ">=0.1.12", optional = true }
# CLI:
typer = ">=0.12.5"
[project.optional-dependencies]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll also need to rebase on the latest main since we now have llama-cpp-python as an extra thanks to your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rescaffold using Substrate
2 participants