Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize Dev Container features #285

Merged
merged 3 commits into from
Feb 24, 2025
Merged

feat: optimize Dev Container features #285

merged 3 commits into from
Feb 24, 2025

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Feb 22, 2025

Changes:

  1. Directly include devcontainers-cli as a Dev Container feature instead of npm.
  2. Don't install the Dev Container CLI in test.sh since it will be available by default, and when working without Docker we shouldn't modify the user's system.
  3. Replace docker-in-docker with docker-outside-of-docker for Python apps, which is what the devcontainers-cli feature uses too and should be more lightweight than a full install of Docker inside the container. EDIT: Does not work on macOS after testing locally.
  4. Specify the Starship major version.
  5. Don't set "remoteUser": "root" as that is the default.
  6. Replace containerEnv with remoteEnv. This closes Prepend to PATH instead of overwriting it #282.

@lsorber lsorber requested a review from sinopeus February 22, 2025 13:21
@lsorber lsorber self-assigned this Feb 22, 2025
@lsorber lsorber merged commit da04b6a into main Feb 24, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepend to PATH instead of overwriting it
1 participant