feat: optimize Dev Container features #285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
devcontainers-cli
as a Dev Container feature instead ofnpm
.test.sh
since it will be available by default, and when working without Docker we shouldn't modify the user's system.ReplaceEDIT: Does not work on macOS after testing locally.docker-in-docker
withdocker-outside-of-docker
for Python apps, which is what thedevcontainers-cli
feature uses too and should be more lightweight than a full install of Docker inside the container."remoteUser": "root"
as that is the default.containerEnv
withremoteEnv
. This closes Prepend to PATH instead of overwriting it #282.