Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frogend/bug] Settings/admin page does not respond into vertical mode soon enough #1663

Closed
trysdyn opened this issue Mar 31, 2023 · 1 comment · Fixed by #1764
Closed

[frogend/bug] Settings/admin page does not respond into vertical mode soon enough #1663

trysdyn opened this issue Mar 31, 2023 · 1 comment · Fixed by #1764
Assignees
Labels
bug Something isn't working frontend Frontend-related stuff

Comments

@trysdyn
Copy link

trysdyn commented Mar 31, 2023

Describe the bug with a clear and concise description of what the bug is. Please include screenshots of any visual issues.

On viewing /settings in a browser window constrained to 1080 pixel width, the content pane overflows the browser window and results in an awkward horizontal scroll situation for text fields; also the logged in user box in the nav bar is extremely crunched to my avatar and the first two letters of my name.

Shrinking the window to about 960 pixel width will cause the responsive design to kick in and move to a more compact presentation; but in between the two, the presentation is a little strange.

This is new behavior I believe may have been introduced by some padding out of the sidebar in 0746ef7

Super duper low severity nit-pick :)

What's your GoToSocial Version?

v0.7.1 git-60639a6

Browser version

Firefox 111.0.1 (64-bit)

What happened?

I pulled in head to fix the pgsql prune bug (thank you BTW!) and navigated to /settings to see the changes brought in by 0746ef7

I view and administrate GtS from a system that has a flipped orientation display, so the browser window is 1080 pixels wide. The settings frontend changes look neat, but in this orientation the main content pane overflows the window horizontally about 15%, meaning all the text fields require horizontal scrolling to fully see and the "who is logged in" element in the nav bar is extremely crunched.

What you expected to happen?

The page moves to its compact/mobile display mode before resorting to horizontal overflow in text fields and crunching elements.

It looks like the @media query sets the marker line between modes at 60rem but if we want to avoid that horizontal scroll it needs to be 72-75rem (or deeper layout changes happen like shrinking the max width of the content panel).

How to reproduce it?

View /settings in a window somewhere between 960 and 1080 pixels wide.

Anything else we need to know?

No response

@trysdyn trysdyn added bug Something isn't working frontend Frontend-related stuff labels Mar 31, 2023
@tsmethurst
Copy link
Contributor

Aha, thank you :)

@tsmethurst tsmethurst added this to the v0.9.0 Spicy Sloth milestone May 10, 2023
@tsmethurst tsmethurst changed the title [bug] Settings/admin page does not respond into vertical mode soon enough [frogend/bug] Settings/admin page does not respond into vertical mode soon enough May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants