From 0fd90e5cc0786e76a6e67fceb07a18f46d9fe522 Mon Sep 17 00:00:00 2001 From: tsmethurst Date: Wed, 14 Jun 2023 14:33:00 +0200 Subject: [PATCH] [chore/bugfix] Demote failed inbox forwarding to warn log rather than error return --- internal/federation/federatingactor.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/federation/federatingactor.go b/internal/federation/federatingactor.go index 7081144847..72647040a2 100644 --- a/internal/federation/federatingactor.go +++ b/internal/federation/federatingactor.go @@ -231,8 +231,9 @@ func (f *federatingActor) PostInboxScheme(ctx context.Context, w http.ResponseWr // is updated, and/or federating callbacks are handled // properly. if !errors.Is(err, db.ErrAlreadyExists) { - err = fmt.Errorf("PostInboxScheme: error calling sideEffectActor.InboxForwarding: %w", err) - return false, gtserror.NewErrorInternalError(err) + // Failed inbox forwarding is not a show-stopper, + // and doesn't even necessarily denote a real error. + l.Warnf("error calling sideEffectActor.InboxForwarding: %q", err) } }