Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniz.h need to be converted to a combination of .c/.h #3

Closed
ghost opened this issue Feb 10, 2016 · 2 comments
Closed

miniz.h need to be converted to a combination of .c/.h #3

ghost opened this issue Feb 10, 2016 · 2 comments
Assignees
@suzukiplan
Labels
bug
Milestone
v1.02

Comments

@ghost
Copy link

ghost commented Feb 10, 2016

It's impossible to include code from vgs-bgm-decoder and vgs-mml-compiler in one dynamic library file, because miniz.h defines all functions in only one header file. When compiling two single source file with the miniz.h included in, it will cause a lot of redefinition errors.

Currently I have combine all source files in vgs-bgm-decoder and vgs-mml-compiler into one file in order to get it compiled.
@suzukiplan suzukiplan added the bug label Feb 11, 2016
@suzukiplan suzukiplan self-assigned this Feb 11, 2016
@suzukiplan
Copy link
Owner

Yes, I met it too.
I'll be correct it.

@suzukiplan suzukiplan added this to the v1.02 milestone Feb 11, 2016
This was referenced Feb 11, 2016
Closed
Merged
@suzukiplan
Copy link
Owner

corrected in the #5 of 4db05b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suzukiplan suzukiplan

Labels
bug
Projects
None yet
Milestone
v1.02
Development

No branches or pull requests
1 participant
@suzukiplan