Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter api for dev mode support #2304

Open
JeanJPNM opened this issue Aug 27, 2021 · 2 comments
Open

Adapter api for dev mode support #2304

JeanJPNM opened this issue Aug 27, 2021 · 2 comments
Labels
feature / enhancement New feature or request size:large significant feature with tricky design questions and multi-day implementation
Milestone

Comments

@JeanJPNM
Copy link
Contributor

JeanJPNM commented Aug 27, 2021

Describe the problem

#2051 allows us to integrate svelte kit into a node server, but it only currently works in production mode. While this is an excelent change, we still need to be able to use it on dev mode.
#2426 also requires dev mode support for ALL adapters that opt to support that functionality.

Describe the proposed solution

Making adapters able to optionally export a plugin with additional methods to use svelte kit specific functionality.

The plugin would have to be explicitly applied by the user. This allows the adapter to optionally receive custom parameters from the user and lets the user decide the order of application of all vite plugins being used.

Alternatives considered

none

Importance

i cannot use SvelteKit without it

Additional Information

@JeanJPNM JeanJPNM changed the title [feat] adapter-node dev mode support adapter-node dev mode support Aug 27, 2021
@benmccann benmccann added this to the 1.0 milestone Aug 27, 2021
@JeanJPNM JeanJPNM changed the title adapter-node dev mode support Adapter api for dev mode support Jan 20, 2022
@benmccann benmccann added the feature / enhancement New feature or request label Mar 17, 2022
@benmccann benmccann added the size:large significant feature with tricky design questions and multi-day implementation label Aug 1, 2022
@benmccann benmccann modified the milestones: 1.0, whenever Aug 1, 2022
@UnlimitedBytes
Copy link

Is there anything new on this topic?

@benmccann
Copy link
Member

Here's a somewhat related issue in Vite: vitejs/vite#14288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request size:large significant feature with tricky design questions and multi-day implementation
Projects
None yet
Development

No branches or pull requests

3 participants