Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esbuild Options on Adapters #5756

Closed
yekta opened this issue Jul 29, 2022 · 1 comment
Closed

Esbuild Options on Adapters #5756

yekta opened this issue Jul 29, 2022 · 1 comment

Comments

@yekta
Copy link

yekta commented Jul 29, 2022

Describe the problem

There is a 3rd party package I'm using which errors out with the Cloudflare adapter and Netlify adapter with the edge option.

The 3rd party package itself is at fault, but I can fix it with define option on esbuild. Unfortunately I can't do that currently with the adapters because they aren't taking esbuild options.

I saw Rich's comment here: #4639. I don't know how can I achieve this without having access to the esbuild options currently. So only thing I can think of is forking the adapters and making a custom version myself which can take esbuild options.

Describe the proposed solution

The ability to pass esbuild options on adapters.

Alternatives considered

Making my own fork.

Importance

would make my life easier

@benmccann
Copy link
Member

Closing as duplicate of #3733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants