Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant generated file check in the Cloudflare worker #9039

Closed
eltigerchino opened this issue Feb 14, 2023 · 0 comments · Fixed by #9040
Closed

Redundant generated file check in the Cloudflare worker #9039

eltigerchino opened this issue Feb 14, 2023 · 0 comments · Fixed by #9040
Labels
pkg:adapter-cloudflare

Comments

@eltigerchino
Copy link
Member

eltigerchino commented Feb 14, 2023 •
edited
Loading

Describe the bug

All requests to /_app/* currently bypass the Cloudflare worker, so the block of code that checks for the path will never run.
This also causes the /_app/version.json file to have its cache-control set incorrectly (browser default) because it's not set in the generated headers config that only affects static requests.

Severity

annoyance

Additional Information

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:adapter-cloudflare
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove redundant Cloudflare worker asset check
1 participant
@eltigerchino