From 279b2d98f74ba1d2e111d8655edd8d36d0cfe693 Mon Sep 17 00:00:00 2001 From: GHOST Date: Sun, 16 Jul 2023 17:13:44 +0000 Subject: [PATCH 1/9] add playground --- packages/playground/README.md | 5 +++ packages/playground/jsconfig.json | 17 ++++++++++ packages/playground/package.json | 18 ++++++++++ packages/playground/src/app.d.ts | 12 +++++++ packages/playground/src/app.html | 12 +++++++ packages/playground/src/lib/index.js | 1 + packages/playground/src/routes/+page.svelte | 2 ++ packages/playground/static/favicon.png | Bin 0 -> 1571 bytes packages/playground/svelte.config.js | 10 ++++++ packages/playground/vite.config.js | 6 ++++ pnpm-lock.yaml | 35 +++++++++++++------- 11 files changed, 106 insertions(+), 12 deletions(-) create mode 100644 packages/playground/README.md create mode 100644 packages/playground/jsconfig.json create mode 100644 packages/playground/package.json create mode 100644 packages/playground/src/app.d.ts create mode 100644 packages/playground/src/app.html create mode 100644 packages/playground/src/lib/index.js create mode 100644 packages/playground/src/routes/+page.svelte create mode 100644 packages/playground/static/favicon.png create mode 100644 packages/playground/svelte.config.js create mode 100644 packages/playground/vite.config.js diff --git a/packages/playground/README.md b/packages/playground/README.md new file mode 100644 index 000000000000..adb570111453 --- /dev/null +++ b/packages/playground/README.md @@ -0,0 +1,5 @@ +You may use this package to experiment with your changes to SvelteKit. + +To prevent any changes you make in this directory from being accidentally committed, run `git update-index --skip-worktree ./**/*.*` in this directory. + +If you would actually like to make some changes to the files here for everyone then run `git update-index --no-skip-worktree ./**/*.*` before committing. diff --git a/packages/playground/jsconfig.json b/packages/playground/jsconfig.json new file mode 100644 index 000000000000..fe45e13fdd06 --- /dev/null +++ b/packages/playground/jsconfig.json @@ -0,0 +1,17 @@ +{ + "extends": "./.svelte-kit/tsconfig.json", + "compilerOptions": { + "allowJs": true, + "checkJs": true, + "esModuleInterop": true, + "forceConsistentCasingInFileNames": true, + "resolveJsonModule": true, + "skipLibCheck": true, + "sourceMap": true, + "strict": true + } + // Path aliases are handled by https://kit.svelte.dev/docs/configuration#alias and https://kit.svelte.dev/docs/configuration#files + // + // If you want to overwrite includes/excludes, make sure to copy over the relevant includes/excludes + // from the referenced tsconfig.json - TypeScript does not merge them in +} diff --git a/packages/playground/package.json b/packages/playground/package.json new file mode 100644 index 000000000000..b25f98149d8f --- /dev/null +++ b/packages/playground/package.json @@ -0,0 +1,18 @@ +{ + "name": "playground", + "version": "0.0.0", + "private": true, + "scripts": { + "dev": "vite dev", + "build": "vite build", + "preview": "vite preview" + }, + "devDependencies": { + "@sveltejs/adapter-auto": "workspace:*", + "@sveltejs/kit": "workspace:*", + "svelte": "^4.0.5", + "typescript": "^5.0.0", + "vite": "^4.4.2" + }, + "type": "module" +} diff --git a/packages/playground/src/app.d.ts b/packages/playground/src/app.d.ts new file mode 100644 index 000000000000..f59b884c51ed --- /dev/null +++ b/packages/playground/src/app.d.ts @@ -0,0 +1,12 @@ +// See https://kit.svelte.dev/docs/types#app +// for information about these interfaces +declare global { + namespace App { + // interface Error {} + // interface Locals {} + // interface PageData {} + // interface Platform {} + } +} + +export {}; diff --git a/packages/playground/src/app.html b/packages/playground/src/app.html new file mode 100644 index 000000000000..effe0d0d266c --- /dev/null +++ b/packages/playground/src/app.html @@ -0,0 +1,12 @@ + + + + + + + %sveltekit.head% + + +
%sveltekit.body%
+ + diff --git a/packages/playground/src/lib/index.js b/packages/playground/src/lib/index.js new file mode 100644 index 000000000000..856f2b6c38ae --- /dev/null +++ b/packages/playground/src/lib/index.js @@ -0,0 +1 @@ +// place files you want to import through the `$lib` alias in this folder. diff --git a/packages/playground/src/routes/+page.svelte b/packages/playground/src/routes/+page.svelte new file mode 100644 index 000000000000..5982b0ae37dd --- /dev/null +++ b/packages/playground/src/routes/+page.svelte @@ -0,0 +1,2 @@ +

Welcome to SvelteKit

+

Visit kit.svelte.dev to read the documentation

diff --git a/packages/playground/static/favicon.png b/packages/playground/static/favicon.png new file mode 100644 index 0000000000000000000000000000000000000000..825b9e65af7c104cfb07089bb28659393b4f2097 GIT binary patch literal 1571 zcmV+;2Hg3HP)Px)-AP12RCwC$UE6KzI1p6{F2N z1VK2vi|pOpn{~#djwYcWXTI_im_u^TJgMZ4JMOsSj!0ma>B?-(Hr@X&W@|R-$}W@Z zgj#$x=!~7LGqHW?IO8+*oE1MyDp!G=L0#^lUx?;!fXv@l^6SvTnf^ac{5OurzC#ZMYc20lI%HhX816AYVs1T3heS1*WaWH z%;x>)-J}YB5#CLzU@GBR6sXYrD>Vw(Fmt#|JP;+}<#6b63Ike{Fuo!?M{yEffez;| zp!PfsuaC)>h>-AdbnwN13g*1LowNjT5?+lFVd#9$!8Z9HA|$*6dQ8EHLu}U|obW6f z2%uGv?vr=KNq7YYa2Roj;|zooo<)lf=&2yxM@e`kM$CmCR#x>gI>I|*Ubr({5Y^rb zghxQU22N}F51}^yfDSt786oMTc!W&V;d?76)9KXX1 z+6Okem(d}YXmmOiZq$!IPk5t8nnS{%?+vDFz3BevmFNgpIod~R{>@#@5x9zJKEHLHv!gHeK~n)Ld!M8DB|Kfe%~123&Hz1Z(86nU7*G5chmyDe ziV7$pB7pJ=96hpxHv9rCR29%bLOXlKU<_13_M8x)6;P8E1Kz6G<&P?$P^%c!M5`2` zfY2zg;VK5~^>TJGQzc+33-n~gKt{{of8GzUkWmU110IgI0DLxRIM>0US|TsM=L|@F z0Bun8U!cRB7-2apz=y-7*UxOxz@Z0)@QM)9wSGki1AZ38ceG7Q72z5`i;i=J`ILzL z@iUO?SBBG-0cQuo+an4TsLy-g-x;8P4UVwk|D8{W@U1Zi z!M)+jqy@nQ$p?5tsHp-6J304Q={v-B>66$P0IDx&YT(`IcZ~bZfmn11#rXd7<5s}y zBi9eim&zQc0Dk|2>$bs0PnLmDfMP5lcXRY&cvJ=zKxI^f0%-d$tD!`LBf9^jMSYUA zI8U?CWdY@}cRq6{5~y+)#h1!*-HcGW@+gZ4B};0OnC~`xQOyH19z*TA!!BJ%9s0V3F?CAJ{hTd#*tf+ur-W9MOURF-@B77_-OshsY}6 zOXRY=5%C^*26z?l)1=$bz30!so5tfABdSYzO+H=CpV~aaUefmjvfZ3Ttu9W&W3Iu6 zROlh0MFA5h;my}8lB0tAV-Rvc2Zs_CCSJnx@d`**$idgy-iMob4dJWWw|21b4NB=LfsYp0Aeh{Ov)yztQi;eL4y5 zMi>8^SzKqk8~k?UiQK^^-5d8c%bV?$F8%X~czyiaKCI2=UH=12.0'} peerDependencies: postcss: ^8.4.19 dependencies: - postcss: 8.4.23 + postcss: 8.4.25 dev: true /postcss-selector-parser@6.0.13: @@ -5585,7 +5596,7 @@ packages: peerDependencies: svelte: ^3.55.0 || ^4.0.0-next.0 || ^4.0.0 dependencies: - '@jridgewell/trace-mapping': 0.3.17 + '@jridgewell/trace-mapping': 0.3.18 chokidar: 3.5.3 fast-glob: 3.2.12 import-fresh: 3.3.0 @@ -5618,8 +5629,8 @@ packages: eslint-scope: 7.2.0 eslint-visitor-keys: 3.4.1 espree: 9.5.2 - postcss: 8.4.23 - postcss-scss: 4.0.6(postcss@8.4.23) + postcss: 8.4.25 + postcss-scss: 4.0.6(postcss@8.4.25) svelte: 4.0.5 dev: true From e703a28fa5f106a13d98ca62cd8540c410be9d52 Mon Sep 17 00:00:00 2001 From: GHOST Date: Tue, 18 Jul 2023 16:03:53 +0000 Subject: [PATCH 2/9] add note on playground to contributing.md --- CONTRIBUTING.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b66bf4733426..22c9ad0aaf17 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,15 @@ cd kit pnpm install ``` -You can now run SvelteKit by linking it into your project with [pnpm `overrides`](https://pnpm.io/package_json#pnpmoverrides): +## Testing Changes + +### Playground + +You can use the playground at `packages/playground` to experiment with your changes to Kit locally. Nothing you change there will get detected by git by default. + +### Linking + +If you don't want to use the playground you can use [pnpm `overrides`](https://pnpm.io/package_json#pnpmoverrides) to link it to your existing project: ```jsonc { From 8830655fd7cef4209c5ccef205a3883812db7189 Mon Sep 17 00:00:00 2001 From: gtmnayan Date: Sun, 20 Aug 2023 08:58:25 +0545 Subject: [PATCH 3/9] mv packages/playground playgrounds/basic --- .../playground => playgrounds/basic}/README.md | 0 .../playground => playgrounds/basic}/jsconfig.json | 0 .../playground => playgrounds/basic}/package.json | 0 .../playground => playgrounds/basic}/src/app.d.ts | 0 .../playground => playgrounds/basic}/src/app.html | 0 .../basic}/src/lib/index.js | 0 .../basic}/src/routes/+page.svelte | 0 .../basic}/static/favicon.png | Bin .../basic}/svelte.config.js | 0 .../playground => playgrounds/basic}/vite.config.js | 0 10 files changed, 0 insertions(+), 0 deletions(-) rename {packages/playground => playgrounds/basic}/README.md (100%) rename {packages/playground => playgrounds/basic}/jsconfig.json (100%) rename {packages/playground => playgrounds/basic}/package.json (100%) rename {packages/playground => playgrounds/basic}/src/app.d.ts (100%) rename {packages/playground => playgrounds/basic}/src/app.html (100%) rename {packages/playground => playgrounds/basic}/src/lib/index.js (100%) rename {packages/playground => playgrounds/basic}/src/routes/+page.svelte (100%) rename {packages/playground => playgrounds/basic}/static/favicon.png (100%) rename {packages/playground => playgrounds/basic}/svelte.config.js (100%) rename {packages/playground => playgrounds/basic}/vite.config.js (100%) diff --git a/packages/playground/README.md b/playgrounds/basic/README.md similarity index 100% rename from packages/playground/README.md rename to playgrounds/basic/README.md diff --git a/packages/playground/jsconfig.json b/playgrounds/basic/jsconfig.json similarity index 100% rename from packages/playground/jsconfig.json rename to playgrounds/basic/jsconfig.json diff --git a/packages/playground/package.json b/playgrounds/basic/package.json similarity index 100% rename from packages/playground/package.json rename to playgrounds/basic/package.json diff --git a/packages/playground/src/app.d.ts b/playgrounds/basic/src/app.d.ts similarity index 100% rename from packages/playground/src/app.d.ts rename to playgrounds/basic/src/app.d.ts diff --git a/packages/playground/src/app.html b/playgrounds/basic/src/app.html similarity index 100% rename from packages/playground/src/app.html rename to playgrounds/basic/src/app.html diff --git a/packages/playground/src/lib/index.js b/playgrounds/basic/src/lib/index.js similarity index 100% rename from packages/playground/src/lib/index.js rename to playgrounds/basic/src/lib/index.js diff --git a/packages/playground/src/routes/+page.svelte b/playgrounds/basic/src/routes/+page.svelte similarity index 100% rename from packages/playground/src/routes/+page.svelte rename to playgrounds/basic/src/routes/+page.svelte diff --git a/packages/playground/static/favicon.png b/playgrounds/basic/static/favicon.png similarity index 100% rename from packages/playground/static/favicon.png rename to playgrounds/basic/static/favicon.png diff --git a/packages/playground/svelte.config.js b/playgrounds/basic/svelte.config.js similarity index 100% rename from packages/playground/svelte.config.js rename to playgrounds/basic/svelte.config.js diff --git a/packages/playground/vite.config.js b/playgrounds/basic/vite.config.js similarity index 100% rename from packages/playground/vite.config.js rename to playgrounds/basic/vite.config.js From 98afe144ac3d9f08f6d82667386376b63d0f4dad Mon Sep 17 00:00:00 2001 From: gtmnayan Date: Sun, 20 Aug 2023 08:58:51 +0545 Subject: [PATCH 4/9] fix lockfile --- pnpm-lock.yaml | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index bd48135e0056..5618bfc8a9d9 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -986,24 +986,6 @@ importers: specifier: ^0.5.6 version: 0.5.6 - packages/playground: - devDependencies: - '@sveltejs/adapter-auto': - specifier: workspace:* - version: link:../adapter-auto - '@sveltejs/kit': - specifier: workspace:* - version: link:../kit - svelte: - specifier: ^4.0.5 - version: 4.1.2 - typescript: - specifier: ^5.0.0 - version: 5.0.4 - vite: - specifier: ^4.4.2 - version: 4.4.9(@types/node@20.4.9)(lightningcss@1.21.5) - sites/kit.svelte.dev: dependencies: d3-geo: From ed06512906c25f4754e450c9bb403e34659849eb Mon Sep 17 00:00:00 2001 From: gtmnayan Date: Sun, 20 Aug 2023 09:00:08 +0545 Subject: [PATCH 5/9] actually fix lockfile --- pnpm-lock.yaml | 18 ++++++++++++++++++ pnpm-workspace.yaml | 1 + 2 files changed, 19 insertions(+) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 5618bfc8a9d9..2e2414cfe3d6 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -986,6 +986,24 @@ importers: specifier: ^0.5.6 version: 0.5.6 + playgrounds/basic: + devDependencies: + '@sveltejs/adapter-auto': + specifier: workspace:* + version: link:../../packages/adapter-auto + '@sveltejs/kit': + specifier: workspace:* + version: link:../../packages/kit + svelte: + specifier: ^4.0.5 + version: 4.1.2 + typescript: + specifier: ^5.0.0 + version: 5.0.4 + vite: + specifier: ^4.4.2 + version: 4.4.9(@types/node@20.4.9)(lightningcss@1.21.5) + sites/kit.svelte.dev: dependencies: d3-geo: diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 7de1bd0a80cc..1f36cf4fb55f 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -8,3 +8,4 @@ packages: - 'packages/kit/test/build-errors/apps/*' - 'packages/create-svelte/templates/*' - '!.test-tmp/**' + - playgrounds/* From 67b4da9a39beb96a574bd3aeda3e0c0547ffe090 Mon Sep 17 00:00:00 2001 From: gtmnayan Date: Sun, 20 Aug 2023 09:07:11 +0545 Subject: [PATCH 6/9] Fix link and remove statement about git tracking in CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 75828c7390db..2abb792f0347 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ pnpm install ### Playground -You can use the playground at `packages/playground` to experiment with your changes to Kit locally. Nothing you change there will get detected by git by default. +You can use the playground at [`playgrounds/basic`](./playgrounds/basic/) to experiment with your changes to Kit locally. ### Linking From e288113bfb3727d88a49b466e64412ebcda1b775 Mon Sep 17 00:00:00 2001 From: gtmnayan Date: Sun, 20 Aug 2023 09:09:07 +0545 Subject: [PATCH 7/9] format --- pnpm-workspace.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 1f36cf4fb55f..061febda7d04 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -8,4 +8,4 @@ packages: - 'packages/kit/test/build-errors/apps/*' - 'packages/create-svelte/templates/*' - '!.test-tmp/**' - - playgrounds/* + - 'playgrounds/*' From 15618a27b5a3aae47344a77c9a93608a8095a511 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 19 Aug 2023 21:17:00 -0700 Subject: [PATCH 8/9] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 2abb792f0347..5ad2751385ca 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ pnpm install ### Playground -You can use the playground at [`playgrounds/basic`](./playgrounds/basic/) to experiment with your changes to Kit locally. +You can use the playground at [`playgrounds/basic`](./playgrounds/basic/) to experiment with your changes to SvelteKit locally. ### Linking From 182b0e91027c93f66027fe1240ec9e2287cfd41e Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Sat, 19 Aug 2023 21:18:27 -0700 Subject: [PATCH 9/9] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5ad2751385ca..5fc83158606b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,7 +24,7 @@ You can use the playground at [`playgrounds/basic`](./playgrounds/basic/) to exp ### Linking -If you don't want to use the playground you can use [pnpm `overrides`](https://pnpm.io/package_json#pnpmoverrides) to link it to your existing project: +If you want to test against an existing project, you can use [pnpm `overrides`](https://pnpm.io/package_json#pnpmoverrides) in that project: ```jsonc {