From 248da9359cd775b323b74a67644099ae618f4769 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Thu, 14 Nov 2024 16:15:20 -0800 Subject: [PATCH 1/3] perf: shorten asset file names --- .changeset/blue-foxes-clean.md | 5 +++++ packages/kit/src/exports/vite/index.js | 8 ++++---- packages/kit/test/apps/basics/test/test.js | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 .changeset/blue-foxes-clean.md diff --git a/.changeset/blue-foxes-clean.md b/.changeset/blue-foxes-clean.md new file mode 100644 index 000000000000..eeb4603fcac3 --- /dev/null +++ b/.changeset/blue-foxes-clean.md @@ -0,0 +1,5 @@ +--- +'@sveltejs/kit': patch +--- + +perf: shorten file names diff --git a/packages/kit/src/exports/vite/index.js b/packages/kit/src/exports/vite/index.js index e6521e979560..812b050d4290 100644 --- a/packages/kit/src/exports/vite/index.js +++ b/packages/kit/src/exports/vite/index.js @@ -640,8 +640,8 @@ async function kit({ svelte_config }) { output: { format: 'esm', entryFileNames: ssr ? '[name].js' : `${prefix}/[name].[hash].${ext}`, - chunkFileNames: ssr ? 'chunks/[name].js' : `${prefix}/chunks/[name].[hash].${ext}`, - assetFileNames: `${prefix}/assets/[name].[hash][extname]`, + chunkFileNames: ssr ? 'chunks/[name].js' : `${prefix}/chunks/[hash].${ext}`, + assetFileNames: `${prefix}/assets/[hash][extname]`, hoistTransitiveImports: false, sourcemapIgnoreList }, @@ -655,8 +655,8 @@ async function kit({ svelte_config }) { rollupOptions: { output: { entryFileNames: `${prefix}/workers/[name]-[hash].js`, - chunkFileNames: `${prefix}/workers/chunks/[name]-[hash].js`, - assetFileNames: `${prefix}/workers/assets/[name]-[hash][extname]`, + chunkFileNames: `${prefix}/workers/chunks/[hash].js`, + assetFileNames: `${prefix}/workers/assets/[hash][extname]`, hoistTransitiveImports: false } } diff --git a/packages/kit/test/apps/basics/test/test.js b/packages/kit/test/apps/basics/test/test.js index fb21412290d6..5b568eeb53f9 100644 --- a/packages/kit/test/apps/basics/test/test.js +++ b/packages/kit/test/apps/basics/test/test.js @@ -50,7 +50,7 @@ test.describe('Imports', () => { ]); } else { expect(sources[0].startsWith('data:image/png;base64,')).toBeTruthy(); - expect(sources[1]).toMatch(/\/_app\/immutable\/assets\/large\.[\w-]+\.jpg/); + expect(sources[1]).toMatch(/\/_app\/immutable\/assets\/[\w-]+\.jpg/); } }); }); From f632fdce60921c843f3a41ba54ab7e3e452babb8 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 15 Nov 2024 16:23:03 -0800 Subject: [PATCH 2/3] revert changes to asset files per discussion on Discord --- packages/kit/src/exports/vite/index.js | 4 ++-- packages/kit/test/apps/basics/test/test.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/kit/src/exports/vite/index.js b/packages/kit/src/exports/vite/index.js index 812b050d4290..b3cdcf2539aa 100644 --- a/packages/kit/src/exports/vite/index.js +++ b/packages/kit/src/exports/vite/index.js @@ -641,7 +641,7 @@ async function kit({ svelte_config }) { format: 'esm', entryFileNames: ssr ? '[name].js' : `${prefix}/[name].[hash].${ext}`, chunkFileNames: ssr ? 'chunks/[name].js' : `${prefix}/chunks/[hash].${ext}`, - assetFileNames: `${prefix}/assets/[hash][extname]`, + assetFileNames: `${prefix}/assets/[name].[hash][extname]`, hoistTransitiveImports: false, sourcemapIgnoreList }, @@ -656,7 +656,7 @@ async function kit({ svelte_config }) { output: { entryFileNames: `${prefix}/workers/[name]-[hash].js`, chunkFileNames: `${prefix}/workers/chunks/[hash].js`, - assetFileNames: `${prefix}/workers/assets/[hash][extname]`, + assetFileNames: `${prefix}/workers/assets/[name]-[hash][extname]`, hoistTransitiveImports: false } } diff --git a/packages/kit/test/apps/basics/test/test.js b/packages/kit/test/apps/basics/test/test.js index 5b568eeb53f9..fb21412290d6 100644 --- a/packages/kit/test/apps/basics/test/test.js +++ b/packages/kit/test/apps/basics/test/test.js @@ -50,7 +50,7 @@ test.describe('Imports', () => { ]); } else { expect(sources[0].startsWith('data:image/png;base64,')).toBeTruthy(); - expect(sources[1]).toMatch(/\/_app\/immutable\/assets\/[\w-]+\.jpg/); + expect(sources[1]).toMatch(/\/_app\/immutable\/assets\/large\.[\w-]+\.jpg/); } }); }); From 2e91dab7595f44a438725e926e99fc543cf69a12 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 15 Nov 2024 16:23:38 -0800 Subject: [PATCH 3/3] Update .changeset/blue-foxes-clean.md --- .changeset/blue-foxes-clean.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/blue-foxes-clean.md b/.changeset/blue-foxes-clean.md index eeb4603fcac3..74957d959df8 100644 --- a/.changeset/blue-foxes-clean.md +++ b/.changeset/blue-foxes-clean.md @@ -2,4 +2,4 @@ '@sveltejs/kit': patch --- -perf: shorten file names +perf: shorten chunk file names