Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: skip jsdoc parsing in various places #2170

Open
dummdidumm opened this issue Sep 26, 2023 · 1 comment
Open

Performance: skip jsdoc parsing in various places #2170

dummdidumm opened this issue Sep 26, 2023 · 1 comment
Labels
perf Performance

Comments

@dummdidumm
Copy link
Member

dummdidumm commented Sep 26, 2023

May result in microscopic wins, every milisecond counts: microsoft/TypeScript#55739
Can use this in svelte2tsx, maybe other locations, too.
Usable in TS 5.3+

@dummdidumm dummdidumm added the perf Performance label Sep 26, 2023
@dummdidumm
Copy link
Member Author

Checked this, not sure if we can leverage this:

  • svelte2tsx checks jsdoc for $props(), we may be able to omit this if we're checking if this is a JS file or not
  • SvelteKit auto typings need it to adjust the imports, again we may be able to omit if we're checking if this is a JS file or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance
Projects
None yet
Development

No branches or pull requests

1 participant