Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reasons, latest release are breaking my app #1777

Closed
PaulMaly opened this issue Oct 17, 2018 · 9 comments
Closed

For some reasons, latest release are breaking my app #1777

PaulMaly opened this issue Oct 17, 2018 · 9 comments

Comments

@PaulMaly
Copy link
Contributor

@Rich-Harris

I don't understand why, but after update Svelte to the latest release, my app stops switching pages via <svelte:component />. Seems, it just adds the next page to the bottom, but the previous page does not unmount from the DOM.

If I downgrade to the previous version everything is ok.

Any ideas?

@Rich-Harris
Copy link
Member

You don't need to @ me, I see all messages (here and on Discord) 😀

Sounds like a regular old-fashioned bug. Can you show us a repro?

@PaulMaly
Copy link
Contributor Author

Actually, it's strange, but I can't reproduce it in REPL using clean use case. I just know that if I update a version of Svelte, my app is breaking. ((

So, seems something works differently than in the previous version. I'll try to reproduce it somehow but can't show exact code because it's commercial.

I just thought you've some ideas about it. Maybe it's on the surface.

You don't need to @ me

Deal ))

@stalkerg
Copy link
Contributor

stalkerg commented Oct 18, 2018

I have problems with the new version too but in a different case.

@btakita
Copy link
Contributor

btakita commented Oct 18, 2018

I'm also having a bunch of errors with 2.4.0. It seems like it has something to do with conditionals wrapped around loops.

Some errors that I see are:

Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted is not a child of this node.

Uncaught TypeError: Cannot read property 'removeChild' of null

Uncaught ReferenceError: div1 is not defined

I'm not able to reproduce on the REPL though.

I've had a few issues with reproducing deep use cases. I wonder if there's a way of tracking the different compilation scenarios.

@Rich-Harris
Copy link
Member

Does the behaviour differ between dev: true and dev: false?

@btakita
Copy link
Contributor

btakita commented Oct 20, 2018

I'm still seeing these errors after 2.4.1. It's with both dev: true and dev: false.

There was an {#if $store__value} wrapped around an {#each $store__value}.

Does the repl support the Store?

@btakita
Copy link
Contributor

btakita commented Oct 23, 2018

This looks like it was reported in #1780

@Rich-Harris
Copy link
Member

Is this issue still live, or was it the same as #1780? Does 2.14.2 fix things?

@PaulMaly
Copy link
Contributor Author

Seems, it works on the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants