Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte dev process usurped my OS default browser #3589

Closed
tcrowe opened this issue Sep 18, 2019 · 1 comment
Closed

Svelte dev process usurped my OS default browser #3589

tcrowe opened this issue Sep 18, 2019 · 1 comment

Comments

@tcrowe
Copy link
Contributor

tcrowe commented Sep 18, 2019

After I created this PR I noticed that when I tried to open another link it was asking me if I approve this new Chrome on my system.

Screen Shot 2019-09-18 at 1 24 53 PM

🤔But, I didn't install a new Chrome... Okay lets "Show Application"

Screen Shot 2019-09-18 at 1 25 48 PM

😑Usually I would run new apps in isolation with npm install --ignore-scripts and/or in a container, but being so trusting of svelte, and in order to pass the svelte tests I did not use the safer approach.


I don't know if anything could or should be done about it but I'm sharing the story as an issue for the community to see and discuss.


Thanks for your time, -TC

@Conduitry
Copy link
Member

Some of Svelte's tests (the custom element ones, where jsdom wouldn't cut it) use Puppeteer, which uses Chromium under the hood. I haven't heard other reports of this behavior (and don't use macOS myself), but presumably this is something you should ask Puppeteer about. We're not doing anything weird or asking them to register Chromium as your default browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants