Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If block passing a reactive value to a function fails #4114

Closed
dxlbnl opened this issue Dec 15, 2019 · 3 comments · Fixed by #4102
Closed

If block passing a reactive value to a function fails #4114

dxlbnl opened this issue Dec 15, 2019 · 3 comments · Fixed by #4102

Comments

@dxlbnl
Copy link
Contributor

dxlbnl commented Dec 15, 2019 •
edited
Loading

Describe the bug
If blocks fail when a couple of conditions are met.
A reactive value is passed to a function in a if condition where the if blocks contain a nested component.

To Reproduce

Expected behavior
If block shows true(true)

Bug introduced in v3.16.4
@bwbroersma
Copy link
Contributor

bwbroersma commented Dec 15, 2019 •
edited
Loading

Definitely also has something to do with the change of dirty logic #4095.

@ghost
Copy link

ghost commented Dec 17, 2019

Yes, this situation and many others are broken.
I'm adding test cases to the outstanding pull request as people notice more situations.

See #4120 for more examples.

@tanhauhau tanhauhau mentioned this issue Dec 18, 2019
Merged
@Conduitry
Copy link
Member

Fixed in v3.16.5 - https://svelte.dev/repl/9c2477a90d314b049d7e64a6fb00b04a?version=3.16.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert remove contextual overflow tanhauhau/svelte
3 participants
@dxlbnl @bwbroersma @Conduitry