Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slots with comments as first element halts builds #4565

Closed
jakobrosenberg opened this issue Mar 16, 2020 · 1 comment · Fixed by #4567
Closed

Slots with comments as first element halts builds #4565

jakobrosenberg opened this issue Mar 16, 2020 · 1 comment · Fixed by #4567
Labels

Comments

@jakobrosenberg
Copy link

To Reproduce

<slot>foobar<!-- placeholder--></slot> works
<slot> <!-- placeholder--></slot> works
<slot></slot> works
<slot/> works
<slot><!-- placeholder--></slot> doesn't work
<slot><!-- placeholder--> </slot> doesn't work
<slot><!-- placeholder--> foobar </slot> doesn't work

Expected behavior
Should build

Svelte version
3.20.0 and 3.20.1

Rollup

Severity
Severe. Breaks apps and shows nothing in the logs.

@Conduitry
Copy link
Member

The fix for this has been finally released in 3.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants