Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use querySelector(':checked') instead of selectedOptions #539

Closed
Rich-Harris opened this issue Apr 30, 2017 · 1 comment
Closed

Use querySelector(':checked') instead of selectedOptions #539

Rich-Harris opened this issue Apr 30, 2017 · 1 comment

Comments

@Rich-Harris
Copy link
Member

From Gitter — it seems selectedOptions isn't supported in IE, and using querySelector means we could enable <select> tests without waiting for a new version of JSDOM.

This is the relevant file.

Thanks for the info @Zirro!

@Zirro
Copy link
Contributor

Zirro commented Apr 30, 2017

I believe I'll have time to submit a PR for this tomorrow. Some of the disabled tests need minor tweaks to pass (not directly related to the selectedOptions/:checked-replacement).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants