Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resolveHostname to match Vite 3 #43

Closed
bluwy opened this issue Jun 5, 2022 · 3 comments · Fixed by #55
Closed

Update resolveHostname to match Vite 3 #43

bluwy opened this issue Jun 5, 2022 · 3 comments · Fixed by #55
Labels
enhancement New feature or request

Comments

@bluwy
Copy link
Member

bluwy commented Jun 5, 2022

Describe the problem

The resolveHostname function has slight mismatch over-time.

Describe the proposed solution

Update it when Vite 3 is near stable. May want to watch out for vitejs/vite#7075

Alternatives considered

Importance

nice to have
@bluwy bluwy added the enhancement New feature or request label Jun 5, 2022
@dominikg
Copy link
Contributor

dominikg commented Jun 5, 2022

do we need to detect vite version and have it work for both or upgrade peer dep to 3 and people have to stick with the old version for 2?

@bluwy
Copy link
Member Author

bluwy commented Jun 6, 2022

Yeah I think we could just detect the vite version and change it. The changes are slight IIRC.

@bluwy
Copy link
Member Author

bluwy commented Jul 11, 2022

vitejs/vite#8986 would make it a lot easier to handle.

@bluwy bluwy mentioned this issue Jul 26, 2022
Merged
@bluwy bluwy closed this as completed in #55 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support vite 3 svitejs/vite-plugin-qrcode
2 participants
@dominikg @bluwy