Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scala] Inconsistency between *Api and *ApiAsyncHelper default parameters #7273

Open
gmarz opened this issue Dec 29, 2017 · 0 comments
Open

[Scala] Inconsistency between *Api and *ApiAsyncHelper default parameters #7273

gmarz opened this issue Dec 29, 2017 · 0 comments
Labels
Client: Scala Issue: Usage/Installation
Milestone
v2.4.0

Comments

@gmarz
Copy link
Contributor

gmarz commented Dec 29, 2017

Description

In #6538, we defaulted non-required Option parameters to None for both sync and async methods in the *Api classes. However, the helper methods in *ApiAsyncHelper (which the methods in *Api simply wrap) default to defaultValue which is inconsistent and also error prone (will open a separate issue for this, but see #6538 (comment) for context /cc @wing328).

Swagger-codegen version

2.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: Scala Issue: Usage/Installation
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
2 participants
@wing328 @gmarz