Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing does not exist for 00-ORDER.txt #2320

Closed
xsebek opened this issue Feb 9, 2025 · 1 comment · Fixed by #2321
Closed

Testing does not exist for 00-ORDER.txt #2320

xsebek opened this issue Feb 9, 2025 · 1 comment · Fixed by #2321
Labels
Bug The observed behaviour is incorrect or unexpected.

Comments

@xsebek
Copy link
Member

xsebek commented Feb 9, 2025

Describe the bug

When run without --debug=testing, a message about an unknown Testing shows up.

To Reproduce

Compare the following:

swarm
swarm --debug=testing

When you open Messages in the main menu.

Expected behavior

When the testing debug option is not selected, the order file should not complain about an unknown Testing directory.

Screenshots

Image

Additional context

The debug options split might have caused this warning message:

@xsebek xsebek added the Bug The observed behaviour is incorrect or unexpected. label Feb 9, 2025
@xsebek
Copy link
Member Author

xsebek commented Feb 9, 2025

I bisected it to this commit:

There, I changed the implementation from not "showing" to not "loading" the Testing folder.

Because we do not start UI in tests, we did not notice that the order file was not handled.

@mergify mergify bot closed this as completed in #2321 Feb 14, 2025
mergify bot pushed a commit that referenced this issue Feb 14, 2025
* refactor `loadScenarioDir`
* do not warn about hidden directories not being present as they were deliberately not loaded
* closes #2320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The observed behaviour is incorrect or unexpected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant