Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Check: Prevent PRs from being merged if there are open conversations #8182

Open
bkhouri opened this issue Dec 19, 2024 · 0 comments
Open
Labels
continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines enhancement

Comments

@bkhouri
Copy link
Contributor

bkhouri commented Dec 19, 2024

In order to ensure all comments were at least read by the author, the project should prevent PRs from being merged if there are open conversations.

It appears GitHub has support for this (See step 8 in https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule#creating-a-branch-protection-rule)

This should apply to all PR that have a destination branch of a release/* branch, including main

@bkhouri bkhouri added enhancement continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration/deployment Changes to the Continuous Integration/Deployment system/pipelines enhancement
Projects
None yet
Development

No branches or pull requests

1 participant