Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in y/n prompts #141

Open
carlynorama opened this issue Jul 21, 2024 · 2 comments
Open

Consistency in y/n prompts #141

carlynorama opened this issue Jul 21, 2024 · 2 comments
Labels
release candidate This issue is a candidate for the next release

Comments

@carlynorama
Copy link

carlynorama commented Jul 21, 2024

Some accept just y or just Y some both. (swifty-install.sh, the intro to the package accepts both.)

MacOS.swift and Linux.swift go their own ways in asking for confirmation (line 121, 135 respectively) in their use() functions for overwriting symlinks, only accepting y, but not warning on a Y.

perhaps these functions should be using

promptForConfirmation(defaultBehavior: Bool) from Utils.swift (line 19)?

@patrickfreed
Copy link
Contributor

Yeah we should definitely be consistent with this. Merging swiftly-install.sh into swiftly itself will help with that too, we just need to make sure to use the same promptForConfirmation everywhere once we do that.

@adam-fowler
Copy link
Contributor

@cmcgee1024 Can you verify your swiftly init PR is consistent

@cmcgee1024 cmcgee1024 self-assigned this Sep 12, 2024
@cmcgee1024 cmcgee1024 added the release candidate This issue is a candidate for the next release label Sep 12, 2024
@cmcgee1024 cmcgee1024 removed their assignment Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release candidate This issue is a candidate for the next release
Projects
None yet
Development

No branches or pull requests

4 participants