Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No "engines" key provided #27

Open
npdev453 opened this issue Nov 12, 2021 · 0 comments
Open

No "engines" key provided #27

npdev453 opened this issue Nov 12, 2021 · 0 comments

Comments

@npdev453
Copy link

Project use optional chaining and recursive flag in mkdirSync that supported only in Node 10+ (or 12+)

It thinks it will be more clearly that engines property will be provided in packages.json

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

At node 8 I got:

./copy-files.hook.js:14
    api.tsconfig.include = api.tsconfig.include?.filter(file => file.endsWith('ts') || file.endsWith('*'));
                                                ^
    SyntaxError: Unexpected token .

Also, I think that a project like this should support the same engines that parent project support, for typescript is node 4.3+
to extend the round of potential users much as possible.

https://github.com/microsoft/TypeScript/blob/main/package.json#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant