Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling editor no longer syncs with previewer after preview scroll #875

Closed
davbeek opened this issue Aug 18, 2024 · 2 comments · Fixed by #906
Closed

Scrolling editor no longer syncs with previewer after preview scroll #875

davbeek opened this issue Aug 18, 2024 · 2 comments · Fixed by #906
Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension
Milestone

Comments

@davbeek
Copy link

davbeek commented Aug 18, 2024

Expected behavior

When the editor scrolls, the previewer should follow (sync) the scrolling

Actual behavior

Initially, after starting VSCode, scrolling syncs both ways (as it should): scrolling the previewer scrolls the editor, and scrolling the editor scrolls the previewer.

Problem is that after I scroll the previewer (and the editor follows the scrolling) and then scroll the editor, the previewer stays put and does not follow (sync) scrolling from the editor anymore. I have observed this in two repositories and with several files.

Closing and reopening VSCode or switching to another rst file in the editor, solves the problem, but only until the first previewer scroll in that new file. So, my current workaround is: every time scrolling no longer syncs from editor to previewer, click another rst file and click back to the original file.

Esbonio 0.95.1
Sphinx 7.3.7
Python 3.12.4
macOS Sonoma 14.6.1
VSCode 1.92.2

Log output

No response

(Optional) Settings from conf.py

No response

@davbeek davbeek added bug Something isn't working triage Issues needing triage labels Aug 18, 2024
@davbeek
Copy link
Author

davbeek commented Aug 19, 2024

I can confirm the same behavior on Windows 10 Pro version 22H2, same versions of Esbonio, Sphinx and VSCode as on Mac.

@alcarney alcarney added ide:vscode Issues that relate to the Esbonio vscode extension and removed triage Issues needing triage labels Aug 19, 2024
@alcarney alcarney added this to Esbonio Aug 19, 2024
@github-project-automation github-project-automation bot moved this to Todo in Esbonio Aug 19, 2024
@alcarney alcarney added this to the 1.0 milestone Aug 19, 2024
@alcarney
Copy link
Member

Thanks for reporting this, I've been seeing the same just haven't got around to investigating yet.

My guess is for some reason, after scrolling the preview VSCode is forgetting which editor is currently being previewed so stops sending the required scroll notifications

@davbeek davbeek changed the title Scrolling editor no longer sync with previewer after preview scroll Scrolling editor no longer syncs with previewer after preview scroll Aug 19, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Esbonio Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ide:vscode Issues that relate to the Esbonio vscode extension
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants