Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths in pyproject.toml's [tool.esbonio.sphinx.pythonCommand] #914

Closed
neongreen-sc opened this issue Oct 15, 2024 · 2 comments · Fixed by #937
Closed

Support relative paths in pyproject.toml's [tool.esbonio.sphinx.pythonCommand] #914

neongreen-sc opened this issue Oct 15, 2024 · 2 comments · Fixed by #937
Labels
enhancement New feature or request lsp Issues that relate to the language server
Milestone

Comments

@neongreen-sc
Copy link

What would you like to see

Right now it seems like paths have to be absolute; would be great if I could specify a path relative to the pyproject.toml file (to make life easier now that VSCode python env is no longer inherited)

@neongreen-sc neongreen-sc added enhancement New feature or request triage Issues needing triage labels Oct 15, 2024
@neongreen-sc
Copy link
Author

(although given that the paths are different between Windows and Linux anyway.. I suppose it doesn't help that much, compared to smth like "let me just give a path to .venv"? which is harder to implement)

@alcarney
Copy link
Member

I agree that the experience with esbonio.sphinx.pythonCommand and venvs is not ideal at the moment. I have been thinking about adding a config syntax like ${venv:/path/to/env} which would expand to /path/to/env/bin/python or path/to/env/Scripts/python.exe depending on the current OS.

As for the relative path, perhaps it's a simple as extending #847 to also cover esbonio.sphinx.pythonCommand? 🤔

@alcarney alcarney added lsp Issues that relate to the language server and removed triage Issues needing triage labels Oct 16, 2024
@alcarney alcarney added this to Esbonio Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Todo in Esbonio Oct 16, 2024
@alcarney alcarney added this to the 1.0 milestone Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Esbonio Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lsp Issues that relate to the language server
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants