Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sentence in 4536 #4537

Closed
nilsdeppe opened this issue Dec 20, 2022 · 1 comment · Fixed by #4625
Closed

Fix sentence in 4536 #4537

nilsdeppe opened this issue Dec 20, 2022 · 1 comment · Fixed by #4625
Assignees
@nilsdeppe @isaaclegred

Comments

@nilsdeppe
Copy link
Member

#4536

Deferred a grammatical thing until later because we need the PR to do simulations over the break. Will address sentence in January.
@nilsdeppe nilsdeppe mentioned this issue Dec 20, 2022
Merged
3 tasks
@isaaclegred
Copy link
Contributor

I'll fix up the docs for the Enthalpy Tests in general, also the argument order for the Enthalpy constructor should be revisited, because it is somewhat unnatural.

@isaaclegred isaaclegred mentioned this issue Jan 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilsdeppe nilsdeppe

@isaaclegred isaaclegred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve enthalpy test documentation isaaclegred/spectre
2 participants
@nilsdeppe @isaaclegred