-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] open a folder with Chinese name and trigger jump fzf to search and select a file, nothing is visible. #108
Comments
first time: 2023-09-05.16-10-21.mp4 |
press left key and right key: 2023-09-05.16-11-40.mp4 |
secode time search: 2023-09-05.16-12-37.mp4 |
Thank you for your report. I will investigate it. |
I cannot reproduce this issue on the latest HEAD. Please try the latest code to see if the issue has gone. issue-108.mp4 |
My code is the latest one. The problem still remains. The strange thing is that I have tried other paths. Some paths don't trigger this issue, while others can stably trigger this issue. |
Do they have any patterns, and how can I reproduce them? |
I found the Rules that trigger bugs. I have a path that is And then I have keymap config:
The down path create method is:
This problem occurs when I use the yazi gd command to open ~/down and then jump fzf. Other directories don't have this problem That is to say, only the Chinese folder in the soft link directory has this problem |
if i directly open path |
Sounds like it might be related to symbolic links. I will investigate it further. |
There are other bugs about link path. After opening link path, whether it is deleted, created, or renamed, it will automatically trigger a jump to the previous level of directory |
Can you record a GIF for this? |
2023-09-06.17-12-12.mp4 |
I made a PR to fix this, can you take a look if the issue has gone |
The problem has been solved |
Thanks for the testing |
It's a little strange that after I updated the main branch code to compile, I found that the first fzf problem was solved, and the problem that automatic jump to the upper level directory was still not solved Then I went back to test the pr branch and found the same thing, the problem that automatic jump problem appeared again |
Unfortunately I can't reproduce the issue, it works fine on my side. I created a symlink directory as you did and put it under HOME, then added files and deleted files to it, but did not encounter a "leave". 123.mp4 |
I know why the first time I tested no problem, because I tested fzf first, but after the test,fzf jumped to the real path, so the automatic leave directory is not a valid test |
I'm not sure how to reproduce your issue. Could you try applying the following patch, then perform the same operation, and paste the results of diff --git forkSrcPrefix/core/src/manager/watcher.rs forkDstPrefix/core/src/manager/watcher.rs
index 1e6c3fcd041c9600d711e831b0ca79d481f61e89..6962b8a7f64649a27458bc670cb02115a462e74e 100644
--- forkSrcPrefix/core/src/manager/watcher.rs
+++ forkDstPrefix/core/src/manager/watcher.rs
@@ -6,6 +6,7 @@ use parking_lot::RwLock;
use shared::Url;
use tokio::{fs, pin, sync::mpsc::{self, UnboundedReceiver}};
use tokio_stream::{wrappers::UnboundedReceiverStream, StreamExt};
+use tracing::info;
use crate::{emit, external, files::{File, Files, FilesOp}};
@@ -156,6 +157,7 @@ impl Watcher {
}
async fn file_changed(urls: &[Url], watched: Arc<RwLock<IndexMap<Url, Option<Url>>>>) {
+ info!("file changed: {:?}", urls);
let Ok(mut mimes) = external::file(urls).await else {
return;
};
@@ -177,6 +179,7 @@ impl Watcher {
}
async fn dir_changed(url: &Url, watched: Arc<RwLock<IndexMap<Url, Option<Url>>>>) {
+ info!("dir changed: {:?}", url);
let linked: Vec<_> = watched
.read()
.iter() By the way, it seems like your password got leaked in the video... |
thanks i will try tomorrow |
You can do a |
2023-09-08.08-34-36.mp4the error caused the automatic jump |
2023-09-08.08-48-26.mp4log: |
Not sure why This might be a Linux-specific behavior. I'll install a Linux to test it shortly. |
The linux symlink seems to be a special file |
That makes sense. Please try the new PR #125 |
it work now |
I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This problem is very strange, and will only happen the first time, when you can not see file list in the current path, press the left arrow key, then press the right arrow key, the file in the current path can be saw again .
After that, I repeated the first operation (jump fzf to search and select a file in the same path). After the selection, I can see file list in the path.
The text was updated successfully, but these errors were encountered: