Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running yazi --version emits warnings to the terminal and breaks yazi-nightly-bin #1668

Closed
GrzegorzKozub opened this issue Sep 21, 2024 · 6 comments · Fixed by #1669
Closed
Labels
bug Something isn't working

Comments

@GrzegorzKozub
Copy link
Contributor

What system are you running Yazi on?

Linux Wayland

What terminal are you running Yazi in?

kitty 0.35.2

yazi --debug output

Yazi
    Version: 0.3.3 (VERGEN_IDEMPOTENT_OUTPUT 2024-09-21)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (VERGEN_IDEMPOTENT_OUTPUT 2024-09-21)

Emulator
    Emulator.via_env: ("tmux-256color", "tmux")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-0")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/bin/zsh")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "$EDITOR \"$@\"", block: true, orphan: false, desc: "Edit", for_: None, spread: true })
    block  : Some(Opener { run: "$EDITOR \"$@\"", block: true, orphan: false, desc: "Edit", for_: None, spread: true })

Multiplexers
    TMUX               : true
    tmux version       : 3.5
    ZELLIJ_SESSION_NAME: None
    Zellij version     : 0.40.1

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: No such file or directory (os error 2)
    magick           : 7.1.1-38
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.1
    chafa            : No such file or directory (os error 2)
    zoxide           : 0.9.6
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/greg/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

The --version argument spits warnings which in turn broken the https://aur.archlinux.org/packages/yazi-nightly-bin package.

●• ./yazi --version
WARNING: The `create_title` under `[input]` now accepts an array instead of a string to support different titles for `create` and `create --dir` command.

Please change `create_title = "Create:"` to `create_title = ["Create:", "Create (dir):"]` in your yazi.toml.

Yazi 0.3.3 (1a1820c 2024-09-21)

Minimal reproducer

yazi --version

Anything else?

I would expect:

●• ./yazi --version
Yazi 0.3.3 (1a1820c 2024-09-21)
@GrzegorzKozub
Copy link
Contributor Author

Thanks!

@GrzegorzKozub
Copy link
Contributor Author

Now that the warnings are in stderr, the same warning appears when I close yazi:

●• yazi
WARNING: The `create_title` under `[input]` now accepts an array instead of a string to support different titles for `create` and `create --dir` command.

Please change `create_title = "Create:"` to `create_title = ["Create:", "Create (dir):"]` in your yazi.toml.

Planning to fix this particular warning?

@sxyazi
Copy link
Owner

sxyazi commented Sep 22, 2024

Warning output is expected behavior because you're using the latest nightly version, where the option has been changed from a string to an array to support #1650. However, it should be printed to stderr so that it doesn't affect version checks in automation scripts.

@5huanghuai
Copy link

TOML Parse Error When Updating create_title in yazi.toml
Description:
Encountered a parsing error when trying to update the create_title in yazi.toml according to the warning message.
Steps to Reproduce:

  1. Open the yazi.toml file.
  2. Change create_title from the following content:
yazi.toml
create_title  =  "Create:" -->
create_title  = [ "Create:", "Create (dir):" ]
  1. Save the file and run the command:
yazi

Error message:

                                                                                                                        
Error: TOML parse error at line 253, column 16
    |
253 | create_title = ["Create:", "Create (dir):"]
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
invalid type: sequence, expected a string

version:

yazi --version                                                                                                                                 
Yazi 0.3.3 (Arch Linux 2024-09-05)

@sxyazi
Copy link
Owner

sxyazi commented Sep 26, 2024

(Arch Linux 2024-09-05)

This isn't the nightly version, the nightly version should be 2024-09-26, https://yazi-rs.github.io/docs/installation#official-binaries

Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants