Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/dom-crawler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.5
Choose a base ref
...
head repository: symfony/dom-crawler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.1.6
Choose a head ref
  • 6 commits
  • 5 files changed
  • 2 contributors

Commits on Sep 25, 2024

  1. Copy the full SHA
    7111520 View commit details
  2. Merge branch '5.4' into 6.4

    * 5.4:
      Add PR template and auto-close PR on subtree split repositories
    nicolas-grekas committed Sep 25, 2024
    Copy the full SHA
    8063ccc View commit details
  3. Merge branch '6.4' into 7.1

    * 6.4:
      Add PR template and auto-close PR on subtree split repositories
    nicolas-grekas committed Sep 25, 2024
    Copy the full SHA
    e36e232 View commit details

Commits on Oct 22, 2024

  1. Copy the full SHA
    89647a5 View commit details

Commits on Oct 25, 2024

  1. Merge branch '5.4' into 6.4

    * 5.4:
      initialize RedisAdapter cursor to 0
      do not skip tests from data providers
      ensure compatibility with Twig 3.15
      [Mime] fix encoding issue with UTF-8 addresses containing doubles spaces
      fix translation file syntax
      [Validator] [Choice] Fix callback option if not array returned
      [DependencyInjection] Fix linting factories implemented via __callStatic
      [DependencyInjection] Fix replacing abstract arguments with bindings
      Minor fixes around parse_url() checks
      Ensure compatibility with mongodb v2
      Add missing translations for Turkish (tr)
    nicolas-grekas committed Oct 25, 2024
    Copy the full SHA
    ae074df View commit details
  2. Merge branch '6.4' into 7.1

    * 6.4:
      initialize RedisAdapter cursor to 0
      do not skip tests from data providers
      ensure compatibility with Twig 3.15
      [Mime] fix encoding issue with UTF-8 addresses containing doubles spaces
      fix translation file syntax
      [Notifier] Improve Telegrams markdown escaping
      [Validator] [Choice] Fix callback option if not array returned
      [DependencyInjection] Fix linting factories implemented via __callStatic
      [DependencyInjection] Fix replacing abstract arguments with bindings
      Minor fixes around parse_url() checks
      Ensure compatibility with mongodb v2
      Add missing translations for Turkish (tr)
    nicolas-grekas committed Oct 25, 2024
    Copy the full SHA
    794ddd5 View commit details
Showing with 31 additions and 5 deletions.
  1. +1 −2 .gitattributes
  2. +8 −0 .github/PULL_REQUEST_TEMPLATE.md
  3. +20 −0 .github/workflows/close-pull-request.yml
  4. +1 −1 AbstractUriElement.php
  5. +1 −2 Form.php
3 changes: 1 addition & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/Tests export-ignore
/phpunit.xml.dist export-ignore
/.gitattributes export-ignore
/.gitignore export-ignore
/.git* export-ignore
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Please do not submit any Pull Requests here. They will be closed.
---

Please submit your PR here instead:
https://github.com/symfony/symfony

This repository is what we call a "subtree split": a read-only subset of that main repository.
We're looking forward to your PR there!
20 changes: 20 additions & 0 deletions .github/workflows/close-pull-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: Close Pull Request

on:
pull_request_target:
types: [opened]

jobs:
run:
runs-on: ubuntu-latest
steps:
- uses: superbrothers/close-pull-request@v3
with:
comment: |
Thanks for your Pull Request! We love contributions.
However, you should instead open your PR on the main repository:
https://github.com/symfony/symfony
This repository is what we call a "subtree split": a read-only subset of that main repository.
We're looking forward to your PR there!
2 changes: 1 addition & 1 deletion AbstractUriElement.php
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ public function __construct(\DOMElement $node, ?string $currentUri = null, ?stri
$this->method = $method ? strtoupper($method) : null;
$this->currentUri = $currentUri;

$elementUriIsRelative = null === parse_url(trim($this->getRawUri()), \PHP_URL_SCHEME);
$elementUriIsRelative = !parse_url(trim($this->getRawUri()), \PHP_URL_SCHEME);
$baseUriIsAbsolute = null !== $this->currentUri && \in_array(strtolower(substr($this->currentUri, 0, 4)), ['http', 'file']);
if ($elementUriIsRelative && !$baseUriIsAbsolute) {
throw new \InvalidArgumentException(sprintf('The URL of the element is relative, so you must define its base URI passing an absolute URL to the constructor of the "%s" class ("%s" was passed).', __CLASS__, $this->currentUri));
3 changes: 1 addition & 2 deletions Form.php
Original file line number Diff line number Diff line change
@@ -180,9 +180,8 @@ public function getUri(): string
$uri = parent::getUri();

if (!\in_array($this->getMethod(), ['POST', 'PUT', 'DELETE', 'PATCH'])) {
$query = parse_url($uri, \PHP_URL_QUERY);
$currentParameters = [];
if ($query) {
if ($query = parse_url($uri, \PHP_URL_QUERY)) {
parse_str($query, $currentParameters);
}