Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components] [Filesystem] Fix the directory structure across versions #4341

Closed
xabbuh opened this issue Oct 19, 2014 · 8 comments
Closed

[Components] [Filesystem] Fix the directory structure across versions #4341

xabbuh opened this issue Oct 19, 2014 · 8 comments

Comments

@xabbuh
Copy link
Member

xabbuh commented Oct 19, 2014

Currently, you cannot switch to the master branch of the filesystem documentation. The reason is that the filesystem.rst file was split into several files in the filesystem/ subdirectory.

However, there is an entry in the redirection map which should ensure that old links don't break. Thus doesn't work at all (probably that's good since it would otherwise be triggered on all versions before 2.6 as well).

To solve this issue, we have to re-add the old filesystem.rst file for master again with some basic contents which links to the new filesystem component index. We also have to remove the entry from the redirection map.

@weaverryan
Copy link
Member

Your solution sounds perfect :).

@wouterj
Copy link
Member

wouterj commented Oct 20, 2014

As I said on IRC, we should do something like http://symfony.com/doc/current/cookbook/form/use_virtuals_forms.html

@stof
Copy link
Member

stof commented Nov 7, 2014

@javiereguiluz couldn't it be possible to handle the redirection map on a per-version basis, allowing to have different redirections in the different versions of the doc ?

@javiereguiluz
Copy link
Member

Fabien worked a lot recently to improve the documentation generator of symfony.com. Now the following URL works as expected: http://symfony.com/doc/master/components/filesystem/introduction.html

Is this enough to solve the problem or are you thinking about something else? Thanks!

@xabbuh
Copy link
Member Author

xabbuh commented Nov 13, 2014

@javiereguiluz
Copy link
Member

is redirected to http://symfony.com/doc/current/components/filesystem/introduction.html which doesn't work

After the recent doc changes, that URL works for me. If it also works for you, we could close this issue as fixed.

@wouterj
Copy link
Member

wouterj commented Dec 14, 2014

@javiereguiluz does this mean redirection maps are now different for each version? That would be great news!

(btw, can de cmf have jt's own redirection map too?)

@xabbuh
Copy link
Member Author

xabbuh commented Dec 16, 2014

I'm closing here since the issue seems to be fixed. Thanks @javiereguiluz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants