Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document for new SymfonyStyle and other changes? #5746

Closed
weaverryan opened this issue Oct 1, 2015 · 4 comments
Closed

Document for new SymfonyStyle and other changes? #5746

weaverryan opened this issue Oct 1, 2015 · 4 comments
Labels
Console hasPR A Pull Request has already been submitted for this issue.
Milestone

Comments

@weaverryan
Copy link
Member

@javiereguiluz I haven't been watching the SymfonyStyle-related changes (the class was new in 2.7) much (though I like the pretty) - is there something we should document related to this?

@weaverryan weaverryan added this to the 2.7 milestone Oct 1, 2015
@javiereguiluz
Copy link
Member

Yes, we should document all the methods available for commands (title(), section(), table(), etc.) We are still deciding some code details (see symfony/symfony#16000) but once we settle on that and test the redesigned commands, we'll start documenting everything.

To better understand what does this new style bring, I like this analogy: so far, commands mixed "CSS" and "HTML". With this new class, commands care only about "semantic HTML" and the "CSS" is automatically applied by Symfony. The result is commands with cleaner and more concise code.

@weaverryan
Copy link
Member Author

@javiereguiluz and that's exactly why I'm excited about documenting them - free, good-looking styling and less styling-stuff in your code to make it happen. thx :)

@xabbuh xabbuh added the Console label Oct 1, 2015
@ghost
Copy link

ghost commented Nov 9, 2015

Same here - I'll feel happy if the documentation is ready.

@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label Dec 20, 2015
@wouterj
Copy link
Member

wouterj commented Dec 20, 2015

There is a PR now: #6017

@wouterj wouterj closed this as completed Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Console hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

4 participants