-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation for Reusable Bundle Best Practices to Mention Testing Extension #5901
Comments
See here for my SO post detailing my setup a bit more (and a bounty, if someone can help sort this out!). Also, ping to @nicolas-grekas @xabbuh and @wouterj, who I suspect will be best equipped for this task. |
IMHO, the doc/README is fine, it tells what it should tell. |
@nicolas-grekas that is true. In my case, since this is a reusable bundle, none of the service configuration code is hit directly, since that's the responsibility of the dependent project to load up and parse. I think ultimately, I need to take an approach similar to the FOS Rest bundle in testing the Extension class, which should resolve the unparsed code issue. Perhaps this approach would be worth mentioning in the Reusable Bundles best practices section. Good for testing all lot of those annotation/configuration type issues. |
Let's close this old issue. Although is true that testing this extension may be a good idea for complex bundles ... I think it's "too much" for most bundles. Let's not add a best-practice recommendation for this yet. We may reconsider this in the future, when we update the docs for creating reusable bundles. Thanks! |
Update:
After some back and forth, realized the issue that was going on was at a more root-level. Based on that, it may be helpful to add some documentation to the Reusable Bundle best practices to mention adding testing for any created Extensions to verify configuration parsing.
Original issue below:
The text was updated successfully, but these errors were encountered: