From 97e072e760160dbb3589b0ef756d9a43f2e154ab Mon Sep 17 00:00:00 2001
From: SimonHeimberg <simon.heimberg@heimberg-ea.ch>
Date: Thu, 7 Jan 2016 20:59:46 +0100
Subject: [PATCH 1/2] use the message argument of assertX functions

Assert functions from PHPUnit do have an optional message argument. This is especially usefull for assertTrue because the message printed on failure does not (and can not) contain any details. Demonstrate this possibility
---
 book/testing.rst | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/book/testing.rst b/book/testing.rst
index ddac77197a6..c9d1969d50d 100644
--- a/book/testing.rst
+++ b/book/testing.rst
@@ -263,7 +263,8 @@ document::
             $client->getResponse()->headers->contains(
                 'Content-Type',
                 'application/json'
-            )
+            ),
+            '"Content-Type" header is NOT "application/json"' // optional message shown on failure
         );
 
         // Assert that the response content contains a string
@@ -272,7 +273,9 @@ document::
         $this->assertRegExp('/foo(bar)?/', $client->getResponse()->getContent());
 
         // Assert that the response status code is 2xx
-        $this->assertTrue($client->getResponse()->isSuccessful());
+        $this->assertTrue($client->getResponse()->isSuccessful(),
+                          'response status code is NOT 2xx'
+                          );
         // Assert that the response status code is 404
         $this->assertTrue($client->getResponse()->isNotFound());
         // Assert a specific 200 status code
@@ -283,7 +286,8 @@ document::
 
         // Assert that the response is a redirect to /demo/contact
         $this->assertTrue(
-            $client->getResponse()->isRedirect('/demo/contact')
+            $client->getResponse()->isRedirect('/demo/contact'),
+            'response is NOT a redirect to /demo/contact'
         );
         // ...or simply check that the response is a redirect to any URL
         $this->assertTrue($client->getResponse()->isRedirect());

From d604bfdf2ba27bbf4986d9a8cb5dd20ae719402d Mon Sep 17 00:00:00 2001
From: WouterJ <waldio.webdesign@gmail.com>
Date: Fri, 8 Jul 2016 15:48:20 +0200
Subject: [PATCH 2/2] Make messages positive

---
 book/testing.rst | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/book/testing.rst b/book/testing.rst
index c9d1969d50d..4e3257885e1 100644
--- a/book/testing.rst
+++ b/book/testing.rst
@@ -264,7 +264,7 @@ document::
                 'Content-Type',
                 'application/json'
             ),
-            '"Content-Type" header is NOT "application/json"' // optional message shown on failure
+            'the "Content-Type" header is "application/json"' // optional message shown on failure
         );
 
         // Assert that the response content contains a string
@@ -273,9 +273,7 @@ document::
         $this->assertRegExp('/foo(bar)?/', $client->getResponse()->getContent());
 
         // Assert that the response status code is 2xx
-        $this->assertTrue($client->getResponse()->isSuccessful(),
-                          'response status code is NOT 2xx'
-                          );
+        $this->assertTrue($client->getResponse()->isSuccessful(), 'response status is 2xx');
         // Assert that the response status code is 404
         $this->assertTrue($client->getResponse()->isNotFound());
         // Assert a specific 200 status code
@@ -287,7 +285,7 @@ document::
         // Assert that the response is a redirect to /demo/contact
         $this->assertTrue(
             $client->getResponse()->isRedirect('/demo/contact'),
-            'response is NOT a redirect to /demo/contact'
+            'response is a redirect to /demo/contact'
         );
         // ...or simply check that the response is a redirect to any URL
         $this->assertTrue($client->getResponse()->isRedirect());