From 8f70057928e2e24161e0902277f8fecc2dcde657 Mon Sep 17 00:00:00 2001 From: Javier Spagnoletti Date: Sat, 23 Jul 2016 17:14:36 -0300 Subject: [PATCH 1/3] [Contributing] [Standards] Do not use spaces inside/around offset accessors | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | N/A Ref: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2089 --- contributing/code/standards.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contributing/code/standards.rst b/contributing/code/standards.rst index 47f4417ea40..f9d315f5ff4 100644 --- a/contributing/code/standards.rst +++ b/contributing/code/standards.rst @@ -176,7 +176,9 @@ Structure Read more at :ref:`contributing-code-conventions-deprecations`; * Do not use ``else``, ``elseif``, ``break`` after ``if`` and ``case`` conditions - which return or throw something. + which return or throw something; + +* Do not use spaces inside/around offset accessors; Naming Conventions ------------------ From c28af3f63a0a2fae2e9f9c9f96534a7d7cfe6cff Mon Sep 17 00:00:00 2001 From: Javier Spagnoletti Date: Sat, 23 Jul 2016 17:26:53 -0300 Subject: [PATCH 2/3] Replace semicolon with full stop --- contributing/code/standards.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/code/standards.rst b/contributing/code/standards.rst index f9d315f5ff4..48824125307 100644 --- a/contributing/code/standards.rst +++ b/contributing/code/standards.rst @@ -178,7 +178,7 @@ Structure * Do not use ``else``, ``elseif``, ``break`` after ``if`` and ``case`` conditions which return or throw something; -* Do not use spaces inside/around offset accessors; +* Do not use spaces inside/around offset accessors. Naming Conventions ------------------ From bbd5b28c5007b803d6c7cfd7143fae8778e4f57f Mon Sep 17 00:00:00 2001 From: Javier Spagnoletti Date: Tue, 26 Jul 2016 22:03:12 -0300 Subject: [PATCH 3/3] Reworded statement --- contributing/code/standards.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributing/code/standards.rst b/contributing/code/standards.rst index 48824125307..bb268977261 100644 --- a/contributing/code/standards.rst +++ b/contributing/code/standards.rst @@ -178,7 +178,7 @@ Structure * Do not use ``else``, ``elseif``, ``break`` after ``if`` and ``case`` conditions which return or throw something; -* Do not use spaces inside/around offset accessors. +* Do not use spaces around ``[`` offset accessor and before ``]`` offset accessor. Naming Conventions ------------------