Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChartJs] Add support for chart.js:^4.0 #607

Closed
evertharmeling opened this issue Dec 12, 2022 · 2 comments · Fixed by #1389
Closed

[ChartJs] Add support for chart.js:^4.0 #607

evertharmeling opened this issue Dec 12, 2022 · 2 comments · Fixed by #1389
Labels
Feature New Feature

Comments

@evertharmeling
Copy link
Contributor

Looks like it won't have a big effect on the ux-component? But probably best to leave that to the experts ;)
@weaverryan
Copy link
Member

Yea, hopefully we can just change this:

ux/src/Chartjs/assets/package.json

Line 18 in f270fe4

"chart.js": "^3.4.1"
to:

"chart.js": "^3.4.1 || 4.0"

PR welcome :)

@evertharmeling
Copy link
Contributor Author

Thought so too, will take a look at it! ;)

@weaverryan weaverryan added the Feature New Feature label Dec 13, 2022
This was referenced Dec 14, 2022
Closed
Closed
@evertharmeling evertharmeling mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
No milestone
2 participants
@weaverryan @evertharmeling