Add hard warning, so AbstractCheckerTestCase changes are noticiable i…

…n CI (#26)
easy-coding-standard · Jan 3, 2023 · 3aab2d0 · 3aab2d0
1 parent 2b91790
commit 3aab2d0
Showing 1 changed file with 21 additions and 66 deletions.
diff --git a/src/Testing/PHPUnit/AbstractCheckerTestCase.php b/src/Testing/PHPUnit/AbstractCheckerTestCase.php
@@ -12,13 +12,9 @@
 use Symfony\Component\Finder\Finder;
 use Symplify\EasyCodingStandard\FixerRunner\Application\FixerFileProcessor;
 use Symplify\EasyCodingStandard\Kernel\EasyCodingStandardKernel;
-use Symplify\EasyCodingStandard\Parallel\ValueObject\Bridge;
 use Symplify\EasyCodingStandard\SniffRunner\Application\SniffFileProcessor;
 use Symplify\EasyCodingStandard\Testing\Contract\ConfigAwareInterface;
 use Symplify\EasyCodingStandard\Testing\Exception\TestingShouldNotHappenException;
-use Symplify\EasyCodingStandard\ValueObject\Configuration;
-use Symplify\EasyTesting\StaticFixtureSplitter;
-use Symplify\SmartFileSystem\SmartFileInfo;
 use Webmozart\Assert\Assert;
 
 // needed for scoped version to load unprefixed classes; does not have any effect inside the class
@@ -91,65 +87,43 @@ protected function doTestFile(string $filePath): void
     /**
      * @deprecated use doTestFile() instead with \Symplify\EasyCodingStandard\Testing\PHPUnit\StaticFixtureFileFinder::yieldFiles()
      */
-    protected function doTestFileInfo(SplFileInfo $fileInfo): void
+    protected function doTestFileInfo(SplFileInfo $fileInfo): never
     {
-        $staticFixtureSplitter = new StaticFixtureSplitter();
-
-        // @deprecated, to be removed in next PR
-        $smartFileInfo = new SmartFileInfo($fileInfo->getRealPath());
-
-        $inputFileInfoAndExpectedFileInfo = $staticFixtureSplitter->splitFileInfoToLocalInputAndExpectedFileInfos(
-            $smartFileInfo
-        );
-
-        $this->doTestWrongToFixedFile(
-            $inputFileInfoAndExpectedFileInfo->getInputFileInfo(),
-            $inputFileInfoAndExpectedFileInfo->getExpectedFileInfoRealPath()
+        echo sprintf(
+            'The "%s()" method is deprecated and will be removed in ECS 12. Use "doTestFile()" or PHPStan rule/custom rule instead',
+            __METHOD__
         );
+        sleep(5);
+        exit(1);
     }
 
     /**
      * @api
      * File should stay the same and contain 0 errors
+     * @deprecated Use doTestFile() or PHPStan instead
      */
-    protected function doTestCorrectFileInfo(SplFileInfo $fileInfo): void
+    protected function doTestCorrectFileInfo(SplFileInfo $fileInfo): never
     {
-        $this->ensureSomeCheckersAreRegistered();
-
-        if ($this->fixerFileProcessor->getCheckers() !== []) {
-            // @todo separate processFile(): array with errors for parallel,
-            // and processFileToString() for tests only
-            $processedFileContent = $this->fixerFileProcessor->processFileToString($fileInfo);
-            $this->assertStringEqualsFile($fileInfo->getRealPath(), $processedFileContent);
-        }
-
-        if ($this->sniffFileProcessor->getCheckers() !== []) {
-            $processedFileContent = $this->sniffFileProcessor->processFileToString($fileInfo);
-
-            $this->assertStringEqualsFile($fileInfo->getRealPath(), $processedFileContent);
-        }
+        echo sprintf(
+            'The "%s()" method is deprecated and will be removed in ECS 12. Use "doTestFile()" or PHPStan rule/custom rule instead',
+            __METHOD__
+        );
+        sleep(5);
+        exit(1);
     }
 
     /**
      * @api
+     * @deprecated Use doTestFile() or PHPStan instead
      */
-    protected function doTestFileInfoWithErrorCountOf(SplFileInfo $wrongFileInfo, int $expectedErrorCount): void
+    protected function doTestFileInfoWithErrorCountOf(SplFileInfo $wrongFileInfo, int $expectedErrorCount): never
     {
-        $this->ensureSomeCheckersAreRegistered();
-
-        $configuration = new Configuration();
-        $errorsAndFileDiffs = $this->sniffFileProcessor->processFile($wrongFileInfo, $configuration);
-
-        $errors = $errorsAndFileDiffs[Bridge::CODING_STANDARD_ERRORS] ?? [];
-
-        $message = sprintf(
-            'There should be %d errors in "%s" file, but none found.',
-            $expectedErrorCount,
-            $wrongFileInfo->getRealPath()
+        echo sprintf(
+            'The "%s()" method is deprecated and will be removed in ECS 12. Use "doTestFile()" or PHPStan rule/custom rule instead',
+            __METHOD__
         );
-
-        $errorCount = count($errors);
-        $this->assertSame($expectedErrorCount, $errorCount, $message);
+        sleep(5);
+        exit(1);
     }
 
     /**
@@ -166,25 +140,6 @@ protected static function yieldFiles(string $directory, string $suffix = '*.php.
         return $filePaths;
     }
 
-    /**
-     * @deprecated
-     */
-    private function doTestWrongToFixedFile(SplFileInfo $wrongFileInfo, string $fixedFile): void
-    {
-        $this->ensureSomeCheckersAreRegistered();
-
-        if ($this->fixerFileProcessor->getCheckers() !== []) {
-            $processedFileContent = $this->fixerFileProcessor->processFileToString($wrongFileInfo);
-            $this->assertStringEqualsFile($fixedFile, $processedFileContent);
-        } elseif ($this->sniffFileProcessor->getCheckers() !== []) {
-            $processedFileContent = $this->sniffFileProcessor->processFileToString($wrongFileInfo);
-        } else {
-            throw new TestingShouldNotHappenException();
-        }
-
-        $this->assertStringEqualsFile($fixedFile, $processedFileContent);
-    }
-
     private function autoloadCodeSniffer(): void
     {
         foreach (self::POSSIBLE_CODE_SNIFFER_AUTOLOAD_PATHS as $possibleCodeSnifferAutoloadPath) {