Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit CLI Flags / Names #462

Open
jordan-rash opened this issue Dec 20, 2024 · 0 comments
Open

Audit CLI Flags / Names #462

jordan-rash opened this issue Dec 20, 2024 · 0 comments

Comments

@jordan-rash
Copy link
Contributor

jordan-rash commented Dec 20, 2024 •
edited
Loading

Todo:

  • Explicitly define CLI flags

  • Capitalize acronyms

            Any reason why these don't have an explicit `name` like `NodePubXKey`? Does it hyphenate based on capitalization and since `XKey` is in the name, it would split that incorrectly? For clarity I suggest adding an explicit name so there is no question on the semantics.

Originally posted by @bruth in #456 (comment)

Also #456 (comment)_
@jordan-rash jordan-rash mentioned this issue Dec 20, 2024
Merged
@jordan-rash jordan-rash changed the title Explicitly define CLI flags Audit CLI Flags / Names Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jordan-rash