Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Missing Unit Tests #463

Open
jordan-rash opened this issue Dec 20, 2024 · 3 comments
Open

Audit Missing Unit Tests #463

jordan-rash opened this issue Dec 20, 2024 · 3 comments
Labels
defect Suspected defect such as a bug or regression

Comments

@jordan-rash
Copy link
Contributor

Observed behavior

At the moment, most things are tested in the test/ directory in a e2e fashion. Almost all modules are missing unit tests.

Expected behavior

Need to audit all the go modules and add unit tests were appropriate

Nex and NATS version

main

Host environment

No response

Steps to reproduce

No response

@jordan-rash jordan-rash added the defect Suspected defect such as a bug or regression label Dec 20, 2024
@jordan-rash
Copy link
Contributor Author

jordan-rash commented Dec 26, 2024

Main nex node package

└─❯ go test $(go list ./... | grep -v "github.com/synadia-io/nex/test" | grep -v gen | grep -v pb) -cover
        github.com/synadia-io/nex/models                coverage: 0.0% of statements
        github.com/synadia-io/nex/api/nodecontrol               coverage: 0.0% of statements
ok      github.com/synadia-io/nex/internal/logger       (cached)        coverage: 61.1% of statements
ok      github.com/synadia-io/nex/node  1.524s  coverage: 9.2% of statements
ok      github.com/synadia-io/nex/node/internal/actors  1.415s  coverage: 12.4% of statements

CLI

ok      github.com/synadia-io/nex/cmd/nex       7.060s  coverage: 9.6% of statements

Quite a bit of work it necessary here to get decent unit test coverage 😞

@jordan-rash
Copy link
Contributor Author

Once 470 is merged, will open PR and track all the modules of project and get them to some minimal code coverage percentage

@jordan-rash
Copy link
Contributor Author

#473 is the first of a few PRs to improve testing coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

1 participant