Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abort listener should be removed after receiving end #27

Closed
szmarczak opened this issue Aug 2, 2021 · 2 comments
Closed

abort listener should be removed after receiving end #27

szmarczak opened this issue Aug 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@szmarczak
Copy link
Owner

https://github.com/nodejs/node/blob/8d2e66cae33472f5d4017444fd4116a4db5667d2/lib/internal/streams/destroy.js#L311

https://github.com/nodejs/node/blob/8d2e66cae33472f5d4017444fd4116a4db5667d2/lib/internal/streams/readable.js#L1158

request.abort() is called when using for await (cost chunk of response)
@szmarczak szmarczak added the bug Something isn't working label Aug 2, 2021
@szmarczak
Copy link
Owner Author

This is a Node.js bug but I doubt they will fix this so let's fix it here. It just makes the timings incorrect.

@szmarczak
Copy link
Owner Author

Fixed in b8dabf9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szmarczak