Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more general codegen #22

Open
banool opened this issue Jul 31, 2023 · 1 comment
Open

Support for more general codegen #22

banool opened this issue Jul 31, 2023 · 1 comment

Comments

@banool
Copy link
Contributor

banool commented Jul 31, 2023

This is more of a question than an issue. In my fork here I have implemented changes that allow me to skip a lot of the codegen.

https://github.com/banool/async-graphql-reverse/

Notably it is possible to opt out of all the scalars stuff, GraphQL stuff, etc. I've added support for having additional attributes added. With all that combined you can generate types that you use with Serde instead of the async-graphql stack.

My suspicion is that this use case is niche enough that it doesn't really belong in your version of the crate, but I want to see what you think.

For now I'll just make of my fork but if you find all the changes there acceptable, I'd love to merge them in.

Thanks!

@tacogips
Copy link
Owner

tacogips commented Aug 4, 2023

@banool At this moment, this tool only includes functionalities to address the needs of my team, and it is likely lacking many other features. Currently, I believe it's fine to continue incorporating new features unless there are significant disruptive changes (given that, for now, users are likely only my team and yourself, so there shouldn't be others facing issues:). So Your PR is very welcome!

If the user base grows in the future and conflicts or similar issues arise with functionalities, it might be necessary to perform version updates that break backward compatibility in order to streamline those, but I consider this an inevitable step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants