Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unreachable coverage #378

Closed
wyfo opened this issue Jul 23, 2024 · 2 comments
Closed

unreachable coverage #378

wyfo opened this issue Jul 23, 2024 · 2 comments
Labels
C-question Category: A question C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)

Comments

@wyfo
Copy link

wyfo commented Jul 23, 2024

As the name suggests unreachable (and hint::unreachable_unchecked) should never be reached. Does it make sense to automatically exclude unreachable branches from coverage? Is it even possible?
@taiki-e
Copy link
Owner

taiki-e commented Jul 23, 2024

There is an open upstream PR to implement this: rust-lang/rust#120013
See also rust-lang/rust#80549

@taiki-e taiki-e added C-question Category: A question C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream) labels Jul 23, 2024
@wyfo
Copy link
Author

wyfo commented Jul 24, 2024

My bad, I should have looked there first.
I imagine that you prefer having the problem solved on Rust side rather than hacking llvm-cov result, so I will close the issue.

@wyfo wyfo closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-question Category: A question C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wyfo @taiki-e