Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): update docker-compose configurations #53

Merged
merged 10 commits into from
Jun 5, 2023

Conversation

davidtaikocha
Copy link
Member

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code changes in this Pull Request look good. Here are some suggestions:

  • Check the chain ID used in the .env.sample file and make sure it is correct.
  • Consider adding a comment in the .env.sample file to explain what the BOOT_NODES variable is for.
  • Make sure that the correct images are being used for docker-compose services (e.g. gcr.io/evmchain/taiko-geth:askja and gcr.io/evmchain/taiko-client:askja).
  • Consider adding a comment in the docker-compose.yml file to explain what the --p2p.checkPointSyncUrl option is for.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code changes in this pull request seem to be mostly updates to configuration files and image tags.

  • The CHAIN_ID variable in .env.sample has been changed from 167004 to 167005.
  • The PORT_L2_EXECTION_ENGINE_HTTP variable in .env.sample has been changed from 8545 to 8547.
  • The BOOT_NODES variable in .env.sample has been updated with new nodes.
  • The TAIKO_L1_ADDRESS and TAIKO_L2_ADDRESS variables in .env.sample have been updated with new addresses.
  • The L2_THROWAWAY_BLOCK_BUILDER_PRIVATE_KEY variable in .env.sample has been removed.
  • The image tags for l2_execution_engine and taiko_client services in docker-compose.yml have been updated from askja to sha-3c7f5c6 and sha-2213335 respectively.
  • The image tag for taiko_client service in docker-compose.yml has been updated from sha-2213335 to sha-39c3090 respectively.
  • The start-zkevm-chain-rpcd script has been removed from the project.

Overall, the changes seem reasonable, but it would be helpful if more information were provided on why

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this pull request looks good. Here are some comments:

  • The PORT_L2_EXECTION_ENGINE_HTTP and L2_THROWAWAY_BLOCK_BUILDER_PRIVATE_KEY variables have been updated, but their corresponding comments have not been updated.
  • The comment for the L1 Sepolia RPC endpoints has been updated but the variable names have not been changed from L1 to L2.
  • The image tag for the taiko_client_driver has been updated from askja to sha-3c7f5c6, but the image tag for taiko_client_prover_relayer has not been updated.
  • The script/start-zkevm-chain-rpcd.sh script is no longer needed and should be removed.

@davidtaikocha davidtaikocha marked this pull request as ready for review June 4, 2023 17:15
@dionysuzx dionysuzx enabled auto-merge (squash) June 4, 2023 17:32
@dionysuzx dionysuzx merged commit 3ee89e7 into main Jun 5, 2023
@dionysuzx dionysuzx deleted the update-docker-compose branch June 5, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants