feat(protocol): allow guardian prover to pause block proving & verification #17286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): allow guardian prover to pause block proving & verification
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Brechtpd
approved these changes
May 21, 2024
dantaik
changed the title
Brechtpd
reviewed
May 21, 2024
Brechtpd
approved these changes
May 22, 2024
davidtaikocha
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled guardian prover -- once set as the chain pauser -- to pause chain proving if two guardians submits different proofs for the same block in one proving session. If a proof has enough guardian approval and had been used to prove a block, the session history are cleared, so different proof can be submitted again by the guardians for the same block in another "session".
@davidtaikocha I think we should keep this feature disabled (do not set chain pauser to the guardian prover until we fully test this behavior in Hekla.