feat(protocol): improve DelegateOwner to have an optional L2 admin #17445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
…iko-mono into improve_delegate_owner
feat(protocol): improve DelegateOwner to have an optional L2 admin
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adaki2004
approved these changes
May 31, 2024
Brechtpd
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
DelegateOwnerrelies on the bridge to function before it can perform any owner functions. To enable this contract to work even in case of bridge failure, I added a L2adminwhich can perform owner functions too. This admin address shall be a multisig itself.When bridge is battle tested and stable, we can set the admin to 0x0.