Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridge-ui): bigint conversion #17534

Merged
merged 5 commits into from
Jun 9, 2024
Merged

fix(bridge-ui): bigint conversion #17534

merged 5 commits into from
Jun 9, 2024

Conversation

KorbinianK
Copy link
Contributor

  • Responses from relayer were not correctly converted to bigints in typescript, causing invalid claim messages. Fix by converting the response numbers to strings first.

(this hopefully fixes all the failed manual claiming)

@KorbinianK KorbinianK self-assigned this Jun 8, 2024
@dantaik dantaik added this pull request to the merge queue Jun 9, 2024
Merged via the queue into main with commit 4279ccd Jun 9, 2024
9 checks passed
@dantaik dantaik deleted the fix/bridge-ui--bigint-conversion branch June 9, 2024 00:36
@taiko-kitty taiko-kitty mentioned this pull request Jun 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@dantaik dantaik dantaik approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@xiaodino xiaodino Awaiting requested review from xiaodino

Assignees

@KorbinianK KorbinianK

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KorbinianK @dantaik @cyberhorsey