From 106fab6d61f5b62ba590edca5a6ea1a42ba4f431 Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:09:06 +0800 Subject: [PATCH 1/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index ad17b0a1996..2a8c3d51940 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -81,7 +81,7 @@ contract SignalService is EssentialContract, ISignalService { /// @inheritdoc ISignalService function sendSignal(bytes32 signal) external returns (bytes32 slot) { - return _sendSignal(msg.sender, signal, signal); + return _sendSignal(msg.sender, signal, 1); } /// @inheritdoc ISignalService From dc2955148afdce805b90cc963d3a9f97141ccde5 Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:10:59 +0800 Subject: [PATCH 2/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index 2a8c3d51940..503bf5aed61 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -81,7 +81,7 @@ contract SignalService is EssentialContract, ISignalService { /// @inheritdoc ISignalService function sendSignal(bytes32 signal) external returns (bytes32 slot) { - return _sendSignal(msg.sender, signal, 1); + return _sendSignal(msg.sender, signal, bytes32(uint(1))); } /// @inheritdoc ISignalService @@ -172,7 +172,7 @@ contract SignalService is EssentialContract, ISignalService { /// @inheritdoc ISignalService function isSignalSent(address app, bytes32 signal) public view returns (bool) { - return _loadSignalValue(app, signal) == signal; + return _loadSignalValue(app, signal) != 0; } /// @inheritdoc ISignalService From b1097769036c0a296d6857e9aa6f1fe814f0afd1 Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:13:47 +0800 Subject: [PATCH 3/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index 503bf5aed61..05b36ade6b6 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -81,7 +81,7 @@ contract SignalService is EssentialContract, ISignalService { /// @inheritdoc ISignalService function sendSignal(bytes32 signal) external returns (bytes32 slot) { - return _sendSignal(msg.sender, signal, bytes32(uint(1))); + return _sendSignal(msg.sender, signal, bytes32(uint256(1))); } /// @inheritdoc ISignalService From 84c1edde0c6e63dd18423bc8807b46e08d8974fa Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:15:46 +0800 Subject: [PATCH 4/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index 05b36ade6b6..69214b3ca35 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -44,6 +44,7 @@ contract SignalService is EssentialContract, ISignalService { mapping(address => bool) public isAuthorized; uint256[49] private __gap; + event SignalSent(address app, bytes32 signal, bytes32 value); event Authorized(address indexed addr, bool authrized); error SS_EMPTY_PROOF(); @@ -281,6 +282,7 @@ contract SignalService is EssentialContract, ISignalService { assembly { sstore(slot, value) } + emit SignalSent(app, signal, value); } function _cacheChainData( From b5b6d661d84ca4e26fafab66bc58533254248a92 Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:16:18 +0800 Subject: [PATCH 5/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index 69214b3ca35..6fc345f9dac 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -44,7 +44,7 @@ contract SignalService is EssentialContract, ISignalService { mapping(address => bool) public isAuthorized; uint256[49] private __gap; - event SignalSent(address app, bytes32 signal, bytes32 value); + event SignalSent(address app, bytes32 signal, bytes32 slot, bytes32 value); event Authorized(address indexed addr, bool authrized); error SS_EMPTY_PROOF(); @@ -282,7 +282,7 @@ contract SignalService is EssentialContract, ISignalService { assembly { sstore(slot, value) } - emit SignalSent(app, signal, value); + emit SignalSent(app, signal, slot, value); } function _cacheChainData( From 7f2363d503f6ff297904ea5fea9dd529676c2ea3 Mon Sep 17 00:00:00 2001 From: Daniel Wang Date: Wed, 21 Feb 2024 14:18:43 +0800 Subject: [PATCH 6/6] Update SignalService.sol --- packages/protocol/contracts/signal/SignalService.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/protocol/contracts/signal/SignalService.sol b/packages/protocol/contracts/signal/SignalService.sol index 6fc345f9dac..b28b59fb829 100644 --- a/packages/protocol/contracts/signal/SignalService.sol +++ b/packages/protocol/contracts/signal/SignalService.sol @@ -82,7 +82,7 @@ contract SignalService is EssentialContract, ISignalService { /// @inheritdoc ISignalService function sendSignal(bytes32 signal) external returns (bytes32 slot) { - return _sendSignal(msg.sender, signal, bytes32(uint256(1))); + return _sendSignal(msg.sender, signal, signal); } /// @inheritdoc ISignalService