Add control server picker #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an item to the account menu dropdown that allows choosing a control server to use for logins.
|
is there a reason this hasnt been pulled? |
|
@rodrigotellom Do you have an design feedback before we pull this? |
|
Where does the user finds this dropdown? |
It's not merged. |
I'm aware is not merged, but where does this menu is being proposed? Which client? I don't have enough context, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an item to the account menu dropdown that allows choosing a control server to use for logins, to make it easier to test Docker related changes to the control server.
This still needs two pieces:
localhost:31544from inside the Docker VM — it seems to not even be able to find the control serverFixes #8
/cc @dblohm7