Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve custom properties in keyframes #16376

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Preserve custom properties in keyframes #16376

merged 4 commits into from
Feb 21, 2025

Conversation

adamwathan
Copy link
Member

@adamwathan adamwathan commented Feb 8, 2025 •
edited by philipp-spiess
Loading

Closes #16374

Ensure we don't remove custom properties from within @keyframe declarations.

@philipp-spiess philipp-spiess marked this pull request as ready for review February 10, 2025 08:48
@philipp-spiess philipp-spiess requested a review from a team as a code owner February 10, 2025 08:48
@philipp-spiess philipp-spiess mentioned this pull request Feb 19, 2025
Merged
@philipp-spiess philipp-spiess force-pushed the fix/preserve-custom-properties-in-keyframes branch from aba1f7d to ecc9435 Compare February 21, 2025 09:45
philipp-spiess
philipp-spiess approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the change log since after the revert this did not constitute a bug anymore and updated the tests to make sure variables that are only defined by other variables which aren't used are also retained (just to be sure)

@philipp-spiess philipp-spiess merged commit f8d7623 into main Feb 21, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/preserve-custom-properties-in-keyframes branch February 21, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait RobinMalfait left review comments

@philipp-spiess philipp-spiess philipp-spiess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4.0.5] Used css variables are removed from @keyframes
4 participants
@adamwathan @philipp-spiess @RobinMalfait @thecrypticace