From 8c3a1e04717bf60654ccb7853d713b04d28ff745 Mon Sep 17 00:00:00 2001 From: takahirom Date: Wed, 29 May 2024 12:44:34 +0900 Subject: [PATCH 1/4] Try to reproduce file not found exception --- .../takahirom/roborazzi/RoborazziGradleProject.kt | 5 +++++ .../roborazzi/RoborazziGradleProjectTest.kt | 15 +++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt index c4d9eb64c..b9daf665c 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt @@ -17,6 +17,11 @@ class RoborazziGradleProject(val testProjectDir: TemporaryFolder) { return runTask(task) } + fun recordAllVariants(): BuildResult { + val task = "recordRoborazzi" + return runTask(task) + } + fun recordWithFilter1(): BuildResult { val task = "recordRoborazziDebug" return runTask( diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt index a54efa63b..c2dc5a130 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt @@ -53,6 +53,21 @@ class RoborazziGradleProjectTest { } } + @Test + fun recordAllVariantMultipleTimes() { + RoborazziGradleProject(testProjectDir).apply { + for (i in 0 until 10) { + recordAllVariants() + + checkResultsSummaryFileExists() + checkRecordedFileExists("$screenshotAndName.testCapture.png") + checkResultFileExists(resultFileSuffix) + checkRecordedFileNotExists("$screenshotAndName.testCapture_compare.png") + checkRecordedFileNotExists("$screenshotAndName.testCapture_actual.png") + } + } + } + @Test fun whenRecordAndRemovedOutputAndRecordThenSkipAndRestoreTheImages() { RoborazziGradleProject(testProjectDir).apply { From c6bb17310fa1e3243c1c6cc02294fb0d38d3aa3e Mon Sep 17 00:00:00 2001 From: takahirom Date: Wed, 29 May 2024 13:03:30 +0900 Subject: [PATCH 2/4] Use compare task --- .../io/github/takahirom/roborazzi/RoborazziGradleProject.kt | 4 ++-- .../github/takahirom/roborazzi/RoborazziGradleProjectTest.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt index b9daf665c..1af8bb753 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProject.kt @@ -17,8 +17,8 @@ class RoborazziGradleProject(val testProjectDir: TemporaryFolder) { return runTask(task) } - fun recordAllVariants(): BuildResult { - val task = "recordRoborazzi" + fun compareAllVariants(): BuildResult { + val task = "compareRoborazzi" return runTask(task) } diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt index c2dc5a130..188121f9f 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt @@ -54,10 +54,10 @@ class RoborazziGradleProjectTest { } @Test - fun recordAllVariantMultipleTimes() { + fun compareAllVariantMultipleTimes() { RoborazziGradleProject(testProjectDir).apply { for (i in 0 until 10) { - recordAllVariants() + compareAllVariants() checkResultsSummaryFileExists() checkRecordedFileExists("$screenshotAndName.testCapture.png") From 7d0a576260788645f81f1c76e17cd895d1bfbda1 Mon Sep 17 00:00:00 2001 From: takahirom Date: Wed, 29 May 2024 13:50:04 +0900 Subject: [PATCH 3/4] Fix assert --- .../github/takahirom/roborazzi/RoborazziGradleProjectTest.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt index 188121f9f..36cc2f37f 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt @@ -60,10 +60,9 @@ class RoborazziGradleProjectTest { compareAllVariants() checkResultsSummaryFileExists() - checkRecordedFileExists("$screenshotAndName.testCapture.png") checkResultFileExists(resultFileSuffix) - checkRecordedFileNotExists("$screenshotAndName.testCapture_compare.png") - checkRecordedFileNotExists("$screenshotAndName.testCapture_actual.png") + checkRecordedFileExists("$screenshotAndName.testCapture_compare.png") + checkRecordedFileExists("$screenshotAndName.testCapture_actual.png") } } } From b8951bf11de6c9ee72d2f62b3d226552cf5167b6 Mon Sep 17 00:00:00 2001 From: takahirom Date: Wed, 29 May 2024 14:03:13 +0900 Subject: [PATCH 4/4] Remove unneeded assert --- .../io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt | 1 - 1 file changed, 1 deletion(-) diff --git a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt index 36cc2f37f..85d32d1de 100644 --- a/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt +++ b/include-build/roborazzi-gradle-plugin/src/integrationTest/java/io/github/takahirom/roborazzi/RoborazziGradleProjectTest.kt @@ -60,7 +60,6 @@ class RoborazziGradleProjectTest { compareAllVariants() checkResultsSummaryFileExists() - checkResultFileExists(resultFileSuffix) checkRecordedFileExists("$screenshotAndName.testCapture_compare.png") checkRecordedFileExists("$screenshotAndName.testCapture_actual.png") }