[object Promise] instead of link

[gleb-svechnikov]

Hi, I've tried plugin but it returns [object Promise] instead of link into html. Any idea why?
Did I miss something in documentation?

[dc7290]

@rcopstein

I think the PR here has something to do with it
#2

In Nunjucks, asynchronous and synchronous shortcodes are added in different ways.
However, since the PR here has been changed to universal shortcodes.
Nunjucks is now giving me errors.

To solve this, change it so that the following shortcode can be added only for "Nunjucks".

  eleventyConfig.addNunjucksAsyncShortcode('eleventyGoogleFonts', async (value) => {
    return await createInlineCss(value)
  })

[sarahg]

I ran into this as well. You can workaround this issue by downgrading to the previous release, like this:

npm install [email protected]

[rcopstein]

I have to say, it's been a while since I last used eleventy, but as @dc7290 pointed out, we would need a special case for Nunjucks. I would suggest having both eleventyConfig.addNunjucksAsyncShortcode and eleventyConfig.addShortcode pointing to a common function, given that the universal shortcake works for both Liquid and JavaScript out of the box.

I'd say we could, roughly, have something like this:

let eleventyGoogleFontsShortcode = async (value) => {
    return await createInlineCss(value);
}

eleventyConfig.addShortcode('eleventyGoogleFonts', eleventyGoogleFontsShortcode);
eleventyConfig.addNunjucksAsyncShortcode('eleventyGoogleFonts', eleventyGoogleFontsShortcode);

This should add proper support for all engines, with the exception of Handlebars, which does not support async functions.

Any thoughts?

[charliegroll]

@takanorip this is still an open problem - any chance this will ever get addressed? for now, I'm reverting to 0.0.5 as @sarahg suggested (thanks btw)